Ender IO Zoo

Ender IO Zoo

962k Downloads

"Who Needs Jungles?" advancement awarded for organic black dye

quat1024 opened this issue ยท 3 comments

commented

Issue Description:

The "Who Needs Jungles?" advancement is awarded for organic black dye.

What you expected to happen:

Given the name of the advancement, I would expect it to be awarded for organic brown dye.

Steps to reproduce:

  1. Obtain organic black dye.
  2. You will get the "Who Needs Jungles?" advancement.

Affected Versions (Do not use "latest"):

  • EnderIO: 5.0.20
  • EnderCore: 1,12,2-0.5.18
  • Minecraft: 1.12.2
  • Forge: 14.23.2.2611

Your most recent log file where the issue was present:

https://paste.ee/p/ypKVr

commented

Aaand...the IDs for the advancement triggers are messed up, too.

commented

@HenryLoenwind already fixed this i think... let me double check

commented
  "display": {
    "description": {
      "translate": "enderio.advancement.sagmill.4_brown.desc"
    },
    "title": {
      "translate": "enderio.advancement.sagmill.4_brown.name"
    },
    "icon": {
      "item": "enderio:item_material",
      "data": 49
    }
  },
  "criteria": {
    "inv_changed-enderio:item_material": {
      "trigger": "minecraft:inventory_changed",
      "conditions": {
        "items": [
          {
            "item": "enderio:item_material",
            "data": 49

Fixed in Night Build 286