
Existing Item Filter snapshot fails with stack sizes > 127
CD4017BE opened this issue ยท 1 comments
Issue Description:
The Existing Item Filter doesn't list items in its snapshot of a connected inventory if the stack size of that item exceeds 127.
The tested inventory (a Item Buffer from Inductive Logistics):
The resulting snapshot:
see also CD4017BE/InductiveLogistics#24
Steps to reproduce:
- connect a Item Pipe to an inventory that is capable of providing over sized item stacks via its ItemHandler capability (for example: Item Buffers from the mod InductiveLogistics or a Basic Storage Drawer from the mod StorageDrawers)
- put more than 127 of the same item into a single slot of said inventory.
- let the Item Filter take the snapshot.
-> The item won't be listed.
Possible cause of the problem:
The filter probably directly stores the ItemStack gotten from the inventory in its NBT data. But minecrafts default method of storing ItemStacks only uses 8-bit resolution for the stacksize, so it overflows above 127.
How to fix it:
Set the stack size of the retrieved item to 1 (eventually copying necessary) before storing it in the snapshot since the stack size is probably not used by the filter anyway.
Affected Versions:
- EnderIO: 5.0.24
- EnderCore: 0.5.22
- Minecraft: 1.12.2
- Forge: 14.23.3.2655