Ender IO Zoo

Ender IO Zoo

961k Downloads

refined storage destructor issue.

Gamer95875 opened this issue ยท 5 comments

commented

Issue Description:

Note: If this bug occurs in a modpack, please report this to the modpack author. Otherwise, delete this line and add your description here. If you are using an unreleased version of Ender IO (e.g. for 1.8.9), please don't open an issue for features that have not been announced as "finished" or "working".

What happens:

i placed a destructor (from refined storage) accidentally on a refined storage conduit and it crashed the game, i assume the refined storage conduit connected and gave it power.

What you expected to happen:

the conduit to break and nothing else happening.

Steps to reproduce:

1.get refined storage
2.boot up the game
3.place a destructor
...


Affected Versions (Do not use "latest"):

  • EnderIO: 5.0.25
  • EnderCore: 1.12.2-0.5.30
  • Minecraft: 1.12.2
  • Forge: 14.23.4.2705

Your most recent log file where the issue was present:

https://pastebin.com/Eh6Umk1S

commented

That's a bug in refined storage. He's calling getPickBlock() with null for the target parameter, but that parameter is annotated @Nonnull.

https://github.com/raoulvdberge/refinedstorage/blob/mc1.12/src/main/java/com/raoulvdberge/refinedstorage/apiimpl/network/node/NetworkNodeDestructor.java#L105

commented

image
...

commented

Weird. I don't have those annotations as well.

commented

Then check your Forge installation, there supposed to be package annotations all over the vanilla code.

commented

@HenryLoenwind

Is it me or is there no @nonnull on my side?

x