Ender IO Zoo

Ender IO Zoo

Mods
961k Downloads

TiC integration: "Direct" is not teleporting items on one-hit kills

GreyMario opened this issue ยท 1 comments

commented

Issue Description:

The Direct trait is not teleporting items from victims slain in exactly one hit.

What happens:

If the damage from a weapon is enough to kill the victim in one hit, Direct never triggers. The enemy seems to die before the Direct effect is applied to the enemy, so dropped items just hit the floor.

What you expected to happen:

Ideally, Direct should proc on one-hit kills.

Steps to reproduce:

The weapon used to reproduce this in creative testing is a Cleaver with:

  • Manyullyn Large Sword Blade
  • Manyullyn Large Plate
  • Silver Tough Tool Rod (binding)
  • Vibrant Tough Tool Rod (handle)

It is sufficient to one-shot an unarmored undead, but will not kill a Creeper in one hit.

Affected Versions (Do not use "latest"):

  • EnderIO: 1.12.2-5.0.44
  • EnderCore: 1.12.2-0.5.57
  • Minecraft: 1.12.2
  • Forge: 14.23.5.2836
  • SpongeForge? No
  • Optifine? No
  • Single Player and/or Server? Single Player
commented

Actually, maybe I misidentified the issue. I think I'm consistently giving me the items of enemies that I have to hit twice, but when a spider dies in one hit, I get nothing. I'll look into this and rewrite the issue.