Death Urn Player head texture and name missing
Primitive-Human opened this issue · 10 comments
Issue Description:
The player head that spawns when you die with the Death Urn does not copy the player head skin including the name of the player.
What happens:
What happens is that the default Steve skin is shown together with a [unknown player] tooltip showing above it.
What you expected to happen:
The head and tooltip to copy the player's.
Steps to reproduce:
- Hold the Death Urn (and any random other item)
- Die (preferably close to your spawn location)
- Check the texture and name tooltip of the spawned death urn.
...
Affected Versions (Do not use "latest"):
- EnderIO: 5.3.70
- EnderCore: 0.5.76
- Minecraft: 1.12.2
- Forge: 14.23.5.2854
- SpongeForge? no
- Optifine? no
- Single Player
- Launcher: MultiMC (Online mode, no errors connecting to the Authentication, Session, Skins and API servers)
Your most recent log file where the issue was present:
- No error or crash occurs, however I can provide a log if it's really necessary.
- Below is a video recording instead.
https://i.gyazo.com/d17ab5d595d48da657e311b3302a88ae.mp4
Other
Rightclicking the head still returns the items like expected.
Hi,
could you check if there are any errors in the log/console from spawning the urn? If not I probably need to add some debug logging there for the next version. I have to admit, I only tested this in a development environment (i.e. offline mode).
Thanks
PS: Oh, you already said "no error", so you did check the log. Sorry, I'm so used to people not attaching a log because they don't know how to find it...
PS2: Would you be willing to test this with a development build of Ender IO? That way I don't have to push a new cf release with just some spammy logging.
PS3: There would be a log message when the grave block is placed: Log.info("Placed grave for " + player.getName() + " at " + pos);. Does that list the correct player name?
[18:32:28] [Server thread/INFO] [minecraft/MinecraftServer]: [GMan1996: Given [Death Urn] * 1 to GMan1996]
[18:32:28] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] Given [Death Urn] * 1 to GMan1996
[18:32:32] [Server thread/INFO] [minecraft/MinecraftServer]: GMan1996 fell out of the world
[18:32:32] [Server thread/INFO] [enderio]: Placed grave for GMan1996 at BlockPos{x=-2166, y=64, z=-47}
[18:32:32] [Server thread/INFO] [minecraft/MinecraftServer]: [GMan1996: Killed GMan1996]
[18:32:32] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] GMan1996 fell out of the world
[18:32:32] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] Killed GMan1996
That log message does occur with the correct player name.
PS2: Would you be willing to test this with a development build of Ender IO? That way I don't have to push a new cf release with just some spammy logging.
Sure. Do I pull it from the builds off Jenkins?
Tested the 5.3.1329-nightly builds of Ender IO (monolithic), Endergy and Zoo.
Results:
[19:01:16] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] §4This is an §0Ender IO §4development build!
[19:01:16] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] §4It may trash your world at any time!
[19:01:16] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] §4Do not use it for anything but testing!
[19:01:16] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] You have been warned...
[19:01:18] [Server thread/WARN] [minecraft/MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 10316ms behind, skipping 206 tick(s)
[19:01:30] [Server thread/INFO] [minecraft/MinecraftServer]: [GMan1996: Set own game mode to Survival Mode]
[19:01:30] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] Your game mode has been updated to Survival Mode
[19:01:34] [Server thread/INFO] [minecraft/MinecraftServer]: GMan1996 fell out of the world
[19:01:34] [Server thread/INFO] [enderio]: Galacticraft inventory inaccessable. Most likely because it is not installed.
[19:01:34] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] GMan1996 fell out of the world
[19:01:34] [Server thread/INFO] [enderio]: Placed grave for GMan1996 at BlockPos{x=-245, y=65, z=169}
[19:01:34] [Server thread/INFO] [minecraft/MinecraftServer]: [GMan1996: Killed GMan1996]
[19:01:34] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] Killed GMan1996
I need to push the additional logging first, I waited with that until you said it was ok. The next build should have it, if I'm quick it'll be done in 20 minutes.
ok, 2 new log statements: one when rendering the block, one when shift-rightclicking it
[19:34:29] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] Killed GMan1996
[19:34:29] [Client thread/INFO] [enderio]: Created RenderDummy for player [unknown player] UUID=none
[19:34:31] [Client thread/INFO] [enderio]: Created RenderDummy for player [unknown player] UUID=none
[19:34:33] [Server thread/INFO] [minecraft/MinecraftServer]: [GMan1996: Set own game mode to Creative Mode]
[19:34:33] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] Your game mode has been updated to Creative Mode
[19:34:38] [Server thread/INFO] [minecraft/MinecraftServer]: [GMan1996: Set own game mode to Survival Mode]
[19:34:38] [Client thread/INFO] [minecraft/GuiNewChat]: [CHAT] Your game mode has been updated to Survival Mode
[19:34:39] [Client thread/INFO] [enderio]: Owner data: User [uuid=(unknown), name=[unknown player]]
[19:34:39] [Client thread/INFO] [enderio]: Owner data: User [uuid=(unknown), name=[unknown player]]
[19:34:39] [Server thread/INFO] [enderio]: Owner data: User [uuid=snippetysnip, name=GMan1996]
[19:34:39] [Server thread/INFO] [enderio]: Owner data: User [uuid=snippetysnip, name=GMan1996]
Debug lines when looking at (rendering) the block and when shift-rightclicking them.
oh. Now I feel stupid---I fell for the same trap twice. (Last time it was the travel anchor)
I'm using the "owner" field, but that isn't sent to the client. I need to add that data to something that actually is sent to the client for the rendering to work...