Enhanced Attack Indicator

Enhanced Attack Indicator

3M Downloads

question about compatibility with modded items

peow opened this issue ยท 4 comments

commented

I'm playing on version 1.20.1, and I wonder if it's possible to support mod items, such as the Slingshot from Supplementaries, don't mod items use the same cooldown/charge system as Minecraft Vanilla?

commented

id like to know as well, mod is nearly perfect all its missing is modded items compat

commented

I can look at mod support, like checking the class instead of the item (so items that extend bows/crossbows/tridents still work).

Unfortunately, they don't all work the same, they're mostly the same, but not exactly
image
(Not pictured is also when a crossbow is charged, it sets a boolean instead of using the progress)

All modded food should work, and any mods item cooldowns work. I could try to add a generic use-time cooldown, but I don't know how well it would work. I could add a system for mods to tell the mod what it is. Or lastly I could add support manually for some mods.

Besides Supplementaries, is there any other mods with no cooldowns I should look at?

commented

thank you for being interested in adding mod compatibility,

while testing I noticed a few things, really all foods seem to work, and I found in my modpack which items are not identified by the Enhanced Attack Indicator:

its "cooldown" type is similar to that of a bow

its "cooldown" type is similar to that of a bow (can be enchanted with Quick Charge)

these 3 items are consumable items (can only be used once, their cooldown is similar to food)

  • waystones:warp_stone
    2024-03-07_08 29 11
    2024-03-07_08 29 18
    2024-03-07_08 29 18

the warp stone from the Waystones mod is more complex, when you hold it to activate it there is a waiting time, and after you select where you want to teleport to, it enters another type of waiting time, where its durability is reset and only can be used again when its durability is complete, in its Tooltip it says how many seconds are left

the Brush in Minecraft can clean suspicious sand, and using the Useful Brush mod it gains other features, such as break gravel, remove moss from blocks, make chickens drop feathers, etc.

it's not very relevant to put a recharge indicator on this but I thought it would be interesting to mention it here

commented

I can look at mod support, like checking the class instead of the item (so items that extend bows/crossbows/tridents still work).

Unfortunately, they don't all work the same, they're mostly the same, but not exactly image (Not pictured is also when a crossbow is charged, it sets a boolean instead of using the progress)

All modded food should work, and any mods item cooldowns work. I could try to add a generic use-time cooldown, but I don't know how well it would work. I could add a system for mods to tell the mod what it is. Or lastly I could add support manually for some mods.

Besides Supplementaries, is there any other mods with no cooldowns I should look at?

Fabric 1.20.1
soulsweapons:galeforce and soulsweapons:darkmoon_longbow are missing their indicator Marium's Soulslike Weaponry

Desktop.2024.03.09.-.02.39.41.01.mp4