[Issue] Render issue with Sync
gatoborrachon opened this issue ยท 12 comments
Describe the bug
The chambers from Sync mod are badly rendered, the glass is the only thing rendered.
To Reproduce
Steps to reproduce the behavior:
- Install Sync and Entity Culling
- Place any Sync chamber
- See error
Expected behavior
you will see how it is badly rendered
Screenshots
Without EntityCulling
With Entity Culling 2.0.0
Versions
Entity Culling: 2.0.0
Forge: 14.23.5.2854
Minecraft: 1.12.2
Sync: 7.1.0
Other
Latest log (upload as a file):
2020-12-15-4.log
Singleplayer
Other mods (Sync):
I'm unable to reproduce the issue with only entity culling and sync. Please check what mods are needed to reproduce the issue.
nvm, I will look into it.
you can see the issue? or you mean that you will look into the log and see which mods i have? i have like 200+ so if you want i can do a binary search
It's an issue on their end. I will open an issue on their side but I don't think there will be an update.
Entity Culling changes the way minecraft iterates over the render chunks and checks wether or not to render an entity/tile entity. That means there can't be a blacklist because the vanilla code is never called.
(the blacklist in the config is there to blacklist entities from the skipHiddenTileEntityRendering feature)
oh, ok.
well, the last thing i can say, you know how to fix this inside Sync? i don't know much about coding, but at least i can build a dev environment with the mod, the issue here is that i have no idea what to change, and how do it, but you know which changes do? i know everything has a license, but i will just it for personal use
Wanted to tell you about that right now.
It should be enough to change 1 file:
Sync/src/main/java/me/ichun/mods/sync/client/render/TileRendererDualVertical.java
In there just replace every BlockDualVertical.renderPass with MinecraftForgeClient.getRenderPass()
And add import net.minecraftforge.client.MinecraftForgeClient; to the imports at the top of the file.