Chisel and bits incompatibility
Henkaeru opened this issue · 5 comments
Chiselled blocks from the mod Chisel and bits are unaffected by the block entity culling.
A screenshot showing the setup:
A screenshot showing the entity culling not working on chiselled blocks while working on other block entities:
I'm not 100% sure, but pretty decent chance that these are just not block entities(or rendered as such)? At least that would hurt performance like hell if they got rendered like vanilla chests/signs etc.
Also, are you using distance + zoom to check that they get culled? That has nothing to do with entityculling, thats just the vanilla block entity render distance of I think 32.
For this test, I'm using OrthoCamera (yeah, pretty strange way of testing. But it is using entity culling, my character is at the other side of the wood wall, and when stepping out, the blocks reappear).
I'm not exactly sure it's a block entity. I can't find the exact information, and I don't really want to have a look at the messy code that is chisel and bits.
But many things point to it being a block entity.
First and foremost, using /data get block on a block:
using it on a chiselled block:
Also, the creator of little tiles (chisel and bits but better and forge-only) made this video where he shows a performance increase by fixing a vanilla bug with tiles entities and talking about his blocks as a tile entity:
https://www.youtube.com/watch?v=vTCJbp45pWM
In a comparison video, he talks about chiselled blocks and little tiles blocks as tiles entities. In the description, he also asks himself if chisel and bits fix the above-mentioned issue:
https://www.youtube.com/watch?v=mv08_5iWy1Q
Also, CraftTweaker when using /ct block_info talk about chiselled blocks as being block entities while not doing so on other blocks:
on sand block:
on chiselled block:
In this old issue of chisel and bits, chiselled blocks are considered as tile entities:
ChiselsAndBits/Chisels-and-Bits#205
In the end, I'm sure it's not a block, but I'm not sure if it's a tile entity, maybe some other strange state ? But even if they're not exactly tile entities, maybe it's possible to make it compatible by considering chiselled blocks as tile entities (I have no clue) seeing how similar they are (if they are not actually tile entities).