Project Red: Illumination incompatibility.
ShibeTemple opened this issue · 18 comments
Hello! Is there any way that we could get a compatibility patch for ProjectRed: Illumination? (https://www.curseforge.com/minecraft/mc-mods/project-red-illumination)
Their lit lamps have what seems to be an entity of 'light' that surrounds the block that is incorrectly determined as out of the players' viewport by this entity culling mod.
Thank you for your efforts!
1.16.5
Totally understand. Same situation here. Minecraft is my escape and I wanted to build a cyberpunk style city with these lights in my modpack haha. That's why I am so adamant about solving this issue. Take your time and let me know if there is anything that I can do.
There are no other files named entityculling.json on my system at all. I also know that this issue is not present in the 1.18 version of this mod.
Hello, the mod did not generate a config file. So I looked at the source code and created a config file to the default specifications, however, it did not seem to work. The issue was still present.
entityculling.json
{
"configVersion": 2,
"renderNametagsThroughWalls": true,
"blockEntityWhitelist": [
"create:rope_pulley",
"minecraft:beacon",
"create:hose_pulley",
"betterend:eternal_pedestal",
"projectred-illumination:white_fixture_light",
"projectred-illumination:orange_fixture_light",
"projectred-illumination:magenta_fixture_light",
"projectred-illumination:light_blue_fixture_light",
"projectred-illumination:yellow_fixture_light",
"projectred-illumination:lime_fixture_light",
"projectred-illumination:pink_fixture_light",
"projectred-illumination:gray_fixture_light",
"projectred-illumination:light_gray_fixture_light",
"projectred-illumination:cyan_fixture_light",
"projectred-illumination:purple_fixture_light",
"projectred-illumination:blue_fixture_light",
"projectred-illumination:brown_fixture_light",
"projectred-illumination:green_fixture_light",
"projectred-illumination:red_fixture_light",
"projectred-illumination:black_fixture_light",
"projectred-illumination:white_inverted_fixture_light",
"projectred-illumination:orange_inverted_fixture_light",
"projectred-illumination:magenta_inverted_fixture_light",
"projectred-illumination:light_blue_inverted_fixture_light",
"projectred-illumination:yellow_inverted_fixture_light",
"projectred-illumination:lime_inverted_fixture_light",
"projectred-illumination:pink_inverted_fixture_light",
"projectred-illumination:gray_inverted_fixture_light",
"projectred-illumination:light_gray_inverted_fixture_light",
"projectred-illumination:cyan_inverted_fixture_light",
"projectred-illumination:purple_inverted_fixture_light",
"projectred-illumination:blue_inverted_fixture_light",
"projectred-illumination:brown_inverted_fixture_light",
"projectred-illumination:green_inverted_fixture_light",
"projectred-illumination:red_inverted_fixture_light",
"projectred-illumination:black_inverted_fixture_light",
"projectred-illumination:white_fallout_light",
"projectred-illumination:orange_fallout_light",
"projectred-illumination:magenta_fallout_light",
"projectred-illumination:light_blue_fallout_light",
"projectred-illumination:yellow_fallout_light",
"projectred-illumination:lime_fallout_light",
"projectred-illumination:pink_fallout_light",
"projectred-illumination:gray_fallout_light",
"projectred-illumination:light_gray_fallout_light",
"projectred-illumination:cyan_fallout_light",
"projectred-illumination:purple_fallout_light",
"projectred-illumination:blue_fallout_light",
"projectred-illumination:brown_fallout_light",
"projectred-illumination:green_fallout_light",
"projectred-illumination:red_fallout_light",
"projectred-illumination:black_fallout_light",
"projectred-illumination:white_inverted_fallout_light",
"projectred-illumination:orange_inverted_fallout_light",
"projectred-illumination:magenta_inverted_fallout_light",
"projectred-illumination:light_blue_inverted_fallout_light",
"projectred-illumination:yellow_inverted_fallout_light",
"projectred-illumination:lime_inverted_fallout_light",
"projectred-illumination:pink_inverted_fallout_light",
"projectred-illumination:gray_inverted_fallout_light",
"projectred-illumination:light_gray_inverted_fallout_light",
"projectred-illumination:cyan_inverted_fallout_light",
"projectred-illumination:purple_inverted_fallout_light",
"projectred-illumination:blue_inverted_fallout_light",
"projectred-illumination:brown_inverted_fallout_light",
"projectred-illumination:green_inverted_fallout_light",
"projectred-illumination:red_inverted_fallout_light",
"projectred-illumination:black_inverted_fallout_light",
"projectred-illumination:white_lantern",
"projectred-illumination:orange_lantern",
"projectred-illumination:magenta_lantern",
"projectred-illumination:light_blue_lantern",
"projectred-illumination:yellow_lantern",
"projectred-illumination:lime_lantern",
"projectred-illumination:pink_lantern",
"projectred-illumination:gray_lantern",
"projectred-illumination:light_gray_lantern",
"projectred-illumination:cyan_lantern",
"projectred-illumination:purple_lantern",
"projectred-illumination:blue_lantern",
"projectred-illumination:brown_lantern",
"projectred-illumination:green_lantern",
"projectred-illumination:red_lantern",
"projectred-illumination:black_lantern",
"projectred-illumination:white_inverted_lantern",
"projectred-illumination:orange_inverted_lantern",
"projectred-illumination:magenta_inverted_lantern",
"projectred-illumination:light_blue_inverted_lantern",
"projectred-illumination:yellow_inverted_lantern",
"projectred-illumination:lime_inverted_lantern",
"projectred-illumination:pink_inverted_lantern",
"projectred-illumination:gray_inverted_lantern",
"projectred-illumination:light_gray_inverted_lantern",
"projectred-illumination:cyan_inverted_lantern",
"projectred-illumination:purple_inverted_lantern",
"projectred-illumination:blue_inverted_lantern",
"projectred-illumination:brown_inverted_lantern",
"projectred-illumination:green_inverted_lantern",
"projectred-illumination:red_inverted_lantern",
"projectred-illumination:black_inverted_lantern",
"projectred-illumination:white_cage_light",
"projectred-illumination:orange_cage_light",
"projectred-illumination:magenta_cage_light",
"projectred-illumination:light_blue_cage_light",
"projectred-illumination:yellow_cage_light",
"projectred-illumination:lime_cage_light",
"projectred-illumination:pink_cage_light",
"projectred-illumination:gray_cage_light",
"projectred-illumination:light_gray_cage_light",
"projectred-illumination:cyan_cage_light",
"projectred-illumination:purple_cage_light",
"projectred-illumination:blue_cage_light",
"projectred-illumination:brown_cage_light",
"projectred-illumination:green_cage_light",
"projectred-illumination:red_cage_light",
"projectred-illumination:black_cage_light",
"projectred-illumination:white_inverted_cage_light",
"projectred-illumination:orange_inverted_cage_light",
"projectred-illumination:magenta_inverted_cage_light",
"projectred-illumination:light_blue_inverted_cage_light",
"projectred-illumination:yellow_inverted_cage_light",
"projectred-illumination:lime_inverted_cage_light",
"projectred-illumination:pink_inverted_cage_light",
"projectred-illumination:gray_inverted_cage_light",
"projectred-illumination:light_gray_inverted_cage_light",
"projectred-illumination:cyan_inverted_cage_light",
"projectred-illumination:purple_inverted_cage_light",
"projectred-illumination:blue_inverted_cage_light",
"projectred-illumination:brown_inverted_cage_light",
"projectred-illumination:green_inverted_cage_light",
"projectred-illumination:red_inverted_cage_light",
"projectred-illumination:black_inverted_cage_light",
"projectred-illumination:white_illumar_lamp",
"projectred-illumination:orange_illumar_lamp",
"projectred-illumination:magenta_illumar_lamp",
"projectred-illumination:light_blue_illumar_lamp",
"projectred-illumination:yellow_illumar_lamp",
"projectred-illumination:lime_illumar_lamp",
"projectred-illumination:pink_illumar_lamp",
"projectred-illumination:gray_illumar_lamp",
"projectred-illumination:light_gray_illumar_lamp",
"projectred-illumination:cyan_illumar_lamp",
"projectred-illumination:purple_illumar_lamp",
"projectred-illumination:blue_illumar_lamp",
"projectred-illumination:brown_illumar_lamp",
"projectred-illumination:green_illumar_lamp",
"projectred-illumination:red_illumar_lamp",
"projectred-illumination:black_illumar_lamp",
"projectred-illumination:white_inverted_illumar_lamp",
"projectred-illumination:orange_inverted_illumar_lamp",
"projectred-illumination:magenta_inverted_illumar_lamp",
"projectred-illumination:light_blue_inverted_illumar_lamp",
"projectred-illumination:yellow_inverted_illumar_lamp",
"projectred-illumination:lime_inverted_illumar_lamp",
"projectred-illumination:pink_inverted_illumar_lamp",
"projectred-illumination:gray_inverted_illumar_lamp",
"projectred-illumination:light_gray_inverted_illumar_lamp",
"projectred-illumination:cyan_inverted_illumar_lamp",
"projectred-illumination:purple_inverted_illumar_lamp",
"projectred-illumination:blue_inverted_illumar_lamp",
"projectred-illumination:brown_inverted_illumar_lamp",
"projectred-illumination:green_inverted_illumar_lamp",
"projectred-illumination:red_inverted_illumar_lamp",
"projectred-illumination:black_inverted_illumar_lamp",
],
"tracingDistance": 128,
"debugMode": false,
"sleepDelay": 10,
"hitboxLimit": 50,
}
First of all it's notworthy that 1.16 Forge is located in this repo https://github.com/tr7zw/EntityCulling-Forge/blob/master/src/main/java/dev/tr7zw/entityculling/EntityCullingMod.java , but from a glance, the config should work(at least generate). So the first guess would be that the working directory doesn't line up because of the launcher or so, so it generates the config file at the wrong location?
I can confirm that this also happens on different computers. I don't see "Error while loading config! Creating a new one!" in the log ever mentioned either.
Just booted a 1.16 forge instance too, and in fact does not generate it... So I guess the config part somehow never worked for Forge 1.16 🤔So I'll probably have to backport the 1.17 version to 1.16(with dual Fabric/Forge) to fix that.
Ok but that looks like something else is going horribly wrong too. The issue is that I'm currently really busy with uni, so might take some time for me to get around into fixing it.
Here is a video of the issue with ProjectRed too: https://www.youtube.com/watch?v=lSvqMSJnMPQ
Hello, there is a culling issue with Tinkers Construct as well... Is there any way to get around this? Maybe force a configuration to run?
No need to go that far, just an issue of timing currently. I think the simplest way would be to fork/unarchive the 1.16 forge repo and hard add the values/figure out why the config is broken. Let me check on how much time a backport from the 1.17 branch will take.
https://github.com/tr7zw/EntityCulling/actions/runs/1675561574 ok somehow did the backport and it took an hour. Not sure how correct everything is because it's 3:40am now and I don't have the time to test everything, but I can confirm that the config is now getting generated(and hopefully loaded too^^).
Seems to have fixed all the issues with rendering, both with Tinkers Construct & Project Red! Awesome! The config generated as well, and these issues are fixed without modifying it. Do you think you could push out the build to CurseForge as an alpha version? Thank you :)
Good to hear that this fixed it, like I mentioned before, it already looked like something went horribly wrong anyway^^. So the 1.16 version had broken tracing and a broken config 😅I'll do some more testing and then publish it to CurseForge.
Looks like there is an issue with multiplayer name tags' locations rapidly changing/jumping when they're occluded.
Meh then I've got the wrong method to update the positions correctly while the entity is out of view. Will fix that later.