Extra Bit Manipulation

Extra Bit Manipulation

15M Downloads

[Compat] Allow Chiseled armour to render when worn by Custom NPCs

thephoenixlodge opened this issue ยท 3 comments

commented

Currently placing chiseled armour in a an NPCs armour slots won't render it on the NPC. After speaking with Noppes (author of CNPCs), it's apparently a matter of allowing the armour to render on zombies.

commented

Vanilla zombies? Because it should render on them already (if it doesn't for you, let me know). If so, not only does that indicate it should already work, but it seems odd to me that it would; chiseled armor is rendered via a render layer that is separately added to the renderers of specific entity classes registered with the render manager. Unless he's importing copies of the render layers of the vanilla zombie class's renderer, I don't see how merely rendering on vanilla zombies would cause rendering on his entities.

If not, I don't see anything in CustomNPCsAPI for adding render layers to any of his entities, and his mod is closed source.

commented

Well, a bit of fiddling revealed the following behaviour. [Tested in 1.12.2 most recent Forge]
image

Under the guise of typical mobs it works fine, but not the default NPC entity. Because the default NPC entity isn't working, the Puppet 'job' implemented by CustomNPCs (Which allows the pose seen above), does not apply to mobs and therefor does not allow one to pose them while wearing Chiseled Armor.

It seems that the NPC entity from Custom NPCs, is not referred to as Zombie internally.
My guess is that it's another entity referred to in the API.

Contacting Noppes directly may yield better answers. I've opened an issue on the mod's curseforge page. https://minecraft.curseforge.com/projects/custom-npcs/issues/1926

commented

This should be fixed as of v3.3.0. Let me know if you run into any problems.