Marshes should spawn relatively rarely in rivers, with an increased chance in rivers near oceans.
Marshes should also spawn in the edges of swamps...perhaps changing the way cattails spawn.

Requires MinecraftForge/MinecraftForge#234

I have moved this into the oneone-whakaaro terrain feature WIP page. closed

Reopened because it addresses a current bug with marsh generation.

@ScottKillen You forgot to reopen this :(

He hasn't forgotten it....it is being fixed for v4.

Not saying he forgot to fix it, saying he forgot to reopen this issue - he said "Reopened", but didn't actually reopen it.

Because they won't exist as they currently do. They are being totally redone and may not even be called marshes going forward.

@Annysia is completely correct, v4 is drasticly messing with the idea of "biomes" so you may not even see marshes as the same thing anymore.

Wasn't sure if you wanted the reply here or on the forums, but this is in response to your question about cattails and grasses.

While I love the cattail, roots, toadstools and leaf piles...to me they spawn a bit to often...as in I have been in green swamps where there is almost no ground at all that doesn't have one of those on it. The way I have seen cattails spawn in nature is that they are normally in clumps and almost always at the edge or actually in the shallow water, but they don't cover the whole area.

Other types of grass/grasses would be a great addition. I am thinking maybe make them taller grasses or a variety of sizes from 1-3 blocks high. Maybe something like sea oats. http://www.sms.si.ed...iola_panicu.htm

Double checked the link and am not sure why it isn't working. It was a link to something on the Smithsonian website...but I love the grass images you found.

My comment wasn't about the frequency of a the green swamp itself. In my 1.25 worlds the swamp itself spawned at a normal frequency...however like you, I am not finding them in 1.32...and don't think I've even come across one yet in 1.32. The spawn I was commenting on was regarding the abundance of cattails, toadstools, roots and leaf piles found within the green swamps.:P (although this was in 1.25) In many instances all the ground within a green swamp was covered with one of the 4 things.

I will go look around and see if I can find one and see if it the spawn rate for those things are still high or if they are more normal.

Hmm...I upped the spawn rates in green swamps because they don't spawn often for me at all in 1.3.2. Would you mind uploading a screenshot.

Ok...so no giant swarms of cattails 😄 I also had another idea of how to do this that would involve mixing cattails and a new grass.

Your link to sea oats doesn't work, but I found a good pick. They are all over the place down here, but I didn't know they were called sea oats. Technically they grow mostly in the sand dunes, but they may work.

Around here, you find clumps of cattails near water, often on the outskirts of marshes or near open water within the marsh.

In the marshes around here, the grass blades are yellowish and cylindrical, tapered to a sharp point at the top, like a giant sewing needle.

I also found a photo of marsh grass from the Northwest that does indeed resemble sea oats:

Heh...yeah that's what I meant, too...

So with the 3.0 changes, I have nerfed the root spawns, because they were over the top. Now, in the green swamp, the cattails lace the water lines sporadically, similar to the way a real marsh feels. When I look across the top of them, they remind me of real marshes...

I think you'll like what you find! 😉

I found a green swamp....and I could not find a single cattail, toadstool, root or leaf pile in it at all...and it was a good size swamp. Not sure if it's a bug or something else going on.

Hmm...I'll look into it.