ExtrabiomesXL

ExtrabiomesXL

3M Downloads

BuildCraft world gen changes broke XBXL oil generation

pantheis opened this issue ยท 5 comments

commented

BuildCraft commit https://github.com/SirSengir/BuildCraft/commit/304fc8cb97ea5f3240d005ab9f4877a306346a29 changed:

public static void generateSurfaceDeposit(World world, int x, int y, int z, int radius) {}

into:

public static void generateSurfaceDeposit(World world, Random rand, int x, int y, int z, int radius) {}

This results in XBXL throwing a caught exception when loading up the world.

commented

Thanks for moving the discussion to the main thread. =) Github is mainly used for ideas discussions on new features and issues with features that we are in the process of adding...not for reporting bugs in already released versions. Also, the community is very helpful at looking at logs and helping fix issues. Maybe someone else is having the same problem you are, but if it's posted here chances are they aren't going to see it.

commented

Please post this in our forums thread along with your forge log. The instructions for what we need are on the OP of the thread. We are using buildcraft on our server and I see plenty of oil deposits and no crashes, so we would need the error log to see what the issue might be.

commented

Posted as requested, also posting it here. This is using any buildcraft compiled on or after the commit I referenced in my initial issue post. This is caused by Buildcraft changing the generateSurfaceDeposit call and XBXL still trying to call the old one. This seems like it will result in XBXL not being able to generate oil deposits on newly generated landscape if using these newer versions of Buildcraft. The server does not crash, this exception is caught and shows up on server startup.

http://pastebin.com/HckzLYH1

Relevant part:
2013-01-22 21:16:41 [FINE] [ExtrabiomesXL] Initializing Buildcraft plugin.
2013-01-22 21:16:41 [INFO] [STDERR] java.lang.NoSuchMethodException: buildcraft.energy.OilPopulate.generateSurfaceDeposit(yc, int, int, int, int)
2013-01-22 21:16:41 [INFO] [STDERR] at java.lang.Class.getMethod(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at extrabiomes.module.amica.buildcraft.BuildcraftAPI.(BuildcraftAPI.java:33)
2013-01-22 21:16:41 [INFO] [STDERR] at extrabiomes.module.amica.buildcraft.BuildcraftPlugin.preInit(BuildcraftPlugin.java:51)
2013-01-22 21:16:41 [INFO] [STDERR] at net.minecraftforge.event.ASMEventHandler_31_BuildcraftPlugin_preInit_Pre.invoke(.dynamic)
2013-01-22 21:16:41 [INFO] [STDERR] at net.minecraftforge.event.ASMEventHandler.invoke(ASMEventHandler.java:35)
2013-01-22 21:16:41 [INFO] [STDERR] at net.minecraftforge.event.EventBus.post(EventBus.java:103)
2013-01-22 21:16:41 [INFO] [STDERR] at extrabiomes.PluginManager.activatePlugins(PluginManager.java:17)
2013-01-22 21:16:41 [INFO] [STDERR] at extrabiomes.Extrabiomes.postInit(Extrabiomes.java:71)
2013-01-22 21:16:41 [INFO] [STDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2013-01-22 21:16:41 [INFO] [STDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at java.lang.reflect.Method.invoke(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:485)
2013-01-22 21:16:41 [INFO] [STDERR] at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at java.lang.reflect.Method.invoke(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:69)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:317)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:300)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:268)
2013-01-22 21:16:41 [INFO] [STDERR] at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:140)
2013-01-22 21:16:41 [INFO] [STDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2013-01-22 21:16:41 [INFO] [STDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at java.lang.reflect.Method.invoke(Unknown Source)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:69)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:317)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:300)
2013-01-22 21:16:41 [INFO] [STDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:268)
2013-01-22 21:16:41 [INFO] [STDERR] at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:83)
2013-01-22 21:16:41 [INFO] [STDERR] at cpw.mods.fml.common.Loader.initializeMods(Loader.java:660)
2013-01-22 21:16:41 [INFO] [STDERR] at cpw.mods.fml.server.FMLServerHandler.finishServerLoading(FMLServerHandler.java:94)
2013-01-22 21:16:41 [INFO] [STDERR] at cpw.mods.fml.common.FMLCommonHandler.onServerStarted(FMLCommonHandler.java:350)
2013-01-22 21:16:41 [INFO] [STDERR] at ho.c(DedicatedServer.java:135)
2013-01-22 21:16:41 [INFO] [STDERR] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:458)
2013-01-22 21:16:41 [INFO] [STDERR] at fy.run(SourceFile:849)
2013-01-22 21:16:41 [INFO] [ExtrabiomesXL] Successfully Loaded.

commented

The changes made in commit https://github.com/pantheis/ExtrabiomesXL/commit/e9a0d0da4cfa8211f37b1afccea4b57f397597c9 fix the above issue, although you may want to look them over to see if you need to handle it differently. I am not completely familiar with the XBXL code base.

commented

Fix has been submitted in #247