![ExtrabiomesXL](https://media.forgecdn.net/avatars/thumbnails/5/711/256/256/635351432498586927.jpg)
Update to Forge 1224
Adaptivity opened this issue · 7 comments
Forge 1224 has a major improvement for mods which adds biomes. Biomes O' Plenty already updated to it: Glitchfiend/BiomesOPlenty@53e0d87
Forge 1224 also has the bug in it where it does not initialize the biome manager fully, making it not backwards compatible with forge recommended...
Since 3.16.0 fully released, maybe it possible to release 3.16.1 for only forge 1224 and also warn people about it?
Well it seems a little pointless in my opinion to release a build that is specifically designed to overcome a bug in forge that will quite likely be patched out of forge come 2225, as a PR has already been submitted. From my understanding the backwards incompatibility was something that thought to be taken care of but was still missed.
Also from reading that commit it, all it does is skip adding the warm and dry biomes, meaning that you would have world border glitches if you updated versions. IE if you were using the game prior to 1224 and then updated to 1224, then the biomes would no longer match up as the biomes would stop spawning. After the bug in forge is fixed then the biomes would start spawning again, resulting in chunk borders breaking again.
I can hardly see how that is an "improvement".
To update it looks like forge implemented the fix for this in 10.13.2.1231
Forge Changelog:
Build 1231:
Adubbz: Fixed desert list initialization. Fixes #1447
#1447 : Backwards Compatibility: BiomeManager.desertBiomes is Never Initialized
BiomeManager.desertBiomes is never initialized in setupBiomes like the other biome types. I know ExtrabiomesXL currently expects it to be there and we just got the following forge error log from someone running forge 1224 demonstrating the issue from us not expecting the NPE: http://paste.ee/p/1VVyB
Although forge 1231 fixes the crashing bug, forge build 1229 changes how biomes are selected so that if you keep the same world you from pre and post 1229 you will have massive chunk borders between the stuff that is generated pre and post update.
There is nothing that we can do on our end as it effect all worlds that have mod biomes in them.
Also if you looked at forge issue #1447 you would note that it was reported by me, so I was alerted the instant that it was fixed, and posted my findings about such on the forums, and retweeted Tahg's tweet about old worlds being broken.
Thanks for your reply and the additional information on chunk borders. :)
I am working on setting up a new server now with the latest recommended,
sounds like from your statement I should not experience the chunk border
issue.
re: 1447 apologies if it is considered an unnecessary update. I noted your
add to the case referencing the forge case, didn't see the update.
- Jeremy
On Sun, Oct 19, 2014 at 1:02 AM, JLBShecky [email protected] wrote:
Although forge 1231 fixes the crashing bug, forge build 1229 changes how
biomes are selected so that if you keep the same world you from pre and
post 1229 you will have massive chunk borders between the stuff that is
generated pre and post update.There is nothing that we can do on our end as it effect all worlds that
have mod biomes in them.Also if you looked at forge issue #1447 you would note that it was
reported by me, so I was alerted the instant that it was fixed, and posted
my findings about such on the forums, and retweeted Tahg's tweet about old
worlds being broken.—
Reply to this email directly or view it on GitHub
#409 (comment)
.