Extreme Reactors

Extreme Reactors

48M Downloads

getNumberOfControlRods() returns the number of fuel rods

jontaylor1985 opened this issue · 2 comments

commented

Looking at the code it appears there is a mistake on line 80 of ExtremeReactors2/src/main/java/it/zerono/mods/extremereactors/gamecontent/multiblock/reactor/computer/ReactorComputerPeripheral.java

This currently causes a reactor with say 15 fuel rods and 5 control rods to return the value 15 when it should be returning the value 5.

The line currently reads

methodConsumer.accept(new ComputerMethod<>("getNumberOfControlRods", wrapControllerValue(IReactorReader::getFuelRodsCount)));

but the method should presumably be reading the IReactorReader::getControlRodsCount

Sorry, I'd create a pull request for you but I have 0 idea how to build minecraft java code and test it.

commented

Fixed in 1.16.5-2.0.24

commented

Good catch, thank you.
I'll fix it in the next release