
Layered snow flickering
FalsePattern opened this issue Β· 8 comments
Looks like a different bug from the other chunk flicker incidents, so i'm moving it here instead.
Clipchamp.mp4
Originally posted by @Omgise in #142 (comment)
@Omgise please try setting DISABLE_BLOCKING_CHUNK_UPDATES
to true
in falsetweaks.cfg, threading
category, and see if it still happens.
This appears to be related to multithreaded chunk rendering. In vanilla anything using a Block instances minX, maxX, minY, maxY, minZ, or maxZ is not thread safe. setBlockBoundsBasedOnState gets called once per block at minimum in RenderBlocks, and in the case of layered snow that changes the maxY. shouldSideBeRendered is called after, and NotFine makes it use the maxY value that was set just before when determining if face culling should occur.
I would suggest rolling back to NotFine 0.1.0 for now.
Angelica implements ASM to make those calls thread-safe which means Angelica's implementation of threaded rendering should just Workβ’.
Be wary: Angelica is still in alpha so be careful what you do with it