
Ambient occlusion fix is broken
makamys opened this issue ยท 7 comments
I just tried and I can reproduce it in a fresh instance.
- Added these mods:
00gasstation-mc1.7.10-0.3.5.jar
falsepatternlib-mc1.7.10-0.10.13.jar
falsetweaks-mc1.7.10-2.0.0-beta0003.jar
- Launched the game, calibrated, got the issue.
- Deleted
config
folder. - Replaced
falsetweaks-mc1.7.10-2.0.0-beta0003.jar
withfalsetweaks-mc1.7.10-2.0.0-alpha0006.jar
- Launched the game, calibrated, no issue.
try calibrating again, the algorithm was changed during the alpha (delete the falsetweaks_userspecific.cfg
file in the config folder, relaunch the game, and then click on the calibration chat message)
So what's the verdict, just disable triangulator for the time being until it's fixed?
try calibrating incorrectly on purpose, so that the images actually mismatch, i probably have a flipped condition somewhere in the render logic
The issue has been found, it was a bug with the triangulation working in the opposite mode because of an oversight while refactoring. Should be fixed in the next release
Yes, it works fine now as of 2.0.2-hotfix1
.
I did some more testing to confirm what happened:
-
In
2.0.0-beta3
, things actually work as expected when triangulation (ENABLE_QUAD_TRIANGULATION
) is disabled. But when it's enabled, the diagonals are always oriented the wrong way. ChangingFLIP_DIAGONALS
has no effect. In my original report, I had triangulation enabled in all cases. -
2.0.2-hotfix1
also works fine if triangulation is disabled. And when it's enabled, the diagonals are oriented the right way. ChangingFLIP_DIAGONALS
still has no effect.
As an aside, it might be a good idea to only show the configuration dialog when triangulation is disabled, since the setting has no effect otherwise, so it's kind of misleading.