Figura

Figura

509k Downloads

Incompatible with Super Secret Revival mod

Aces-and-Jacks opened this issue ยท 34 comments

commented
commented

yup. conflict

commented

I'll message when I find it

commented

I believe this issue has been fixed in the newer version (it appears that you are using latest release, and the issue has been fixed in commits), could you try running latest build?

commented

Note, however, that many avatars will not work in this build because of changes introduced in the time since last release.

commented

https://mclo.gs/VLWAEbr

used figura-0.1.0-rc.13+1.19.2.jar but issue still occurred

commented

I'll try on a fresh instance. maybe there's a mod conflict

commented

dang. almost 10k lines of code

commented

If you know how to do it, could you add JVM flag -Dmixin.debug = true and send output of that? It would show which mod added the mixin that causes the error.

commented

I was just gonna do a binary search. would I put that as an argument?

commented

I've never used java arguments

commented

Yes, since you are using Prism Launcher it would just go in instance settings, Java, Java arguments and add -Dmixin.debug.verbose=true into it. (oops, just figured out that with just -Dmixin.debug=true some mods may cause game to crash)

commented
commented

found the issue

commented

what mod?

commented

I am confused, it appears that the function that fails is generated by mixin, but it is not created at runtime?

uhm, is there any mod that would change ui behavior (or more of sounds)?

commented

like a mod that adds sounds?

commented

not any sound mods that I have. I'll just continue with the binary search

commented

I'm guessing it'd be something they need to do on their end so I'll just close this

commented

Unless anyone else knows how to post an issue there

commented

I don't know what mod is using that information, but pressing any button with an icon instead of text will crash your game because their message is currently being set to null instead of Component.empty().

commented

ah...well i'll continue looking then

commented

working on it

commented

FINALLY. after a while I found the issue. Super Secret Revival is the mod

commented

Huh? Why would something like that mixin into base class? I'll look into what they are doing, but it does seem like not something they should be doing?

commented

And it's the only mod I can't make an issue on either

commented

Huh? Why would something like that mixin into base class? I'll look into what they are doing, but it does seem like not something they should be doing?

this https://git.oat.zone/oat/super-secret-revival/src/branch/1.18/src/main/java/zone/oat/supersecretrevival/mixin/CancelClickSoundMixin.java

commented

As an alternative, Figrua provides functional of enabling post render effects if you wish to have that

commented

Would sending an email to her GitHub profile be a bad way to do it?

commented

The developer of Super Secret Revival has been contacted and confirmed that it'll fix the bug soon ("sometime later today, hopefully")

commented

Got it, thanks. Even though this was an issue I was having and it wasn't from the figura mod, you've been an incredible help

commented

like when I click the + button

commented

in the future, you could always just ping me on github instead!

I've only done commenting on GitHub repositories...actually I forgot about the @ function. Any future issues I'll do that then

commented

hi! yes - i'll fix this in the near future, sorry for the troubles!! (i'm hoping filing issues on my git instance will become a lot less difficult once federation rolls around..)

in the future, you could always just ping me on github instead!

commented

1.3 shooould fix this unless i've royally messed something up