Fluidlogged API

Fluidlogged API

305k Downloads

Fluid interaction crash: Incompatibility with `Plus Tweaks`

Krutoy242 opened this issue ยท 2 comments

commented

Describe the bug
Im using Plus Tweaks mod and its custom fluid interactions:

mods.plustweaks.Liquid.registerLiquidInteraction(ILiquidStack liquid1, ILiquidStack liquid2, IBlockState block, int[] levels);

Game crashes when registered liquid touches another fluidlogged block:

Game freezes after this:

Break glass to crash:

java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=level, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15]} as it does not exist in BlockStateContainer{block=minecraft:cobblestone, properties=[]}
    at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:209)
    at net.minecraft.block.BlockLiquid.handler$zfo000$injectCheckForMixing(BlockLiquid.java:1115)
    at net.minecraft.block.BlockLiquid.checkForMixing(BlockLiquid.java)
    at net.minecraft.block.BlockDynamicLiquid.onBlockAdded(BlockDynamicLiquid.java:304)
    at net.minecraft.world.chunk.Chunk.setBlockState(Chunk.java:614)
    at git.jbredwards.fluidlogged_api.mod.asm.plugins.ASMHooks.setBlockState(ASMHooks.java:1598)

To Reproduce
Steps to reproduce the behavior:

  1. Install Fluidlogged-API-v1.8.1d-mc1.12.2, PlusTweaks, CraftTweaker
  2. Register Liquid Interaction (probably need other mods, because vanilla already have interactions)
  3. Make Liquid from recipe touch another

Logs
crash-2022-08-16_12.00.34-server.txt
crash-2022-08-16_19.09.41-server.txt

Additional context
This is happens for players of E2E-E modpack
Same issue posted on Plus Tweaks tracker too.

commented

This issue is caused by PlusTweaks, it's trying to get the liquid level property from the block holding the fluidstate (rather than getting it from the fluidstate itself). Since it's been a while since that mod's last update (or even last commit for that matter), I'll use asm to fix it from my side until they add an official fix from their side.

commented

fixed in v1.9.0.0