Fluidlogged API

Fluidlogged API

356k Downloads

WorldGenLiquids.generate() performance in v2 -> v3

xJon opened this issue ยท 2 comments

commented

Tested 2.2.7 -> 3.0.5, same seed / world generation area, Tekkit SMP:

All the improvements and bug fixes of v3 are highly appreciated, but I think I will stay on v2 for now until hopefully there's no significant performance hit in updating.

commented

A quick glance suggests it could have something to do with IFluidUpdateHelper#flowInto passing DEFAULT block flags which updates neighbours and cascades into generating more fluid etc.

The initial World#isAreaLoaded looks to be fine, same as 2.0.0, so it shouldn't be that.

commented

Fixed in v3.0.6!

A quick glance suggests it could have something to do with IFluidUpdateHelper#flowInto passing DEFAULT block flags which updates neighbours and cascades into generating more fluid etc.

For now I'm leaving the flags as DEFAULT because that's what vanilla and forge use for their fluid flow logic, and I'm worried that switching them to just SEND_TO_CLIENTS would break something. I'll do more testing to see if this is actually the case though