WorldGenLiquids.generate() performance in v2 -> v3

Question

WorldGenLiquids.generate() performance in v2 -> v3

xJon opened this issue 6 days ago · 1 comments

xJon commented 6 days ago

Tested 2.2.7 -> 3.0.5, same seed / world generation area, Tekkit SMP:

WorldGenLiquids.generate() 0.08% -> WorldGenLiquids.generate() 10.85%
https://spark.lucko.me/EluAnh9lfv -> https://spark.lucko.me/jyXOr53gSX

All the improvements and bug fixes of v3 are highly appreciated, but I think I will stay on v2 for now until hopefully there's no significant performance hit in updating.

Rongmario · Answer 1 · 2025-03-30T23:24:40.000Z

A quick glance suggests it could have something to do with IFluidUpdateHelper#flowInto passing DEFAULT block flags which updates neighbours and cascades into generating more fluid etc.

The initial World#isAreaLoaded looks to be fine, same as 2.0.0, so it shouldn't be that.

Share to