[BUG] Strange Render
Shazuli opened this issue · 5 comments
Describe the bug
Some blocks from other mods looks odd when fluidlogged. In the screenshots I have blocks from OpenComputers and Bibliocraft. I can see why Bibliocraft might look a bit odd as it's a TESR, but I don't understand why OpenComputers does as it uses a regular model file for this particular block (keyboard.json). But then again other mods will have a TESR that looks fine while fluidlogged.
Screenshots
This is caused by the those blocks not implementing Block.getBlockFaceShape() correctly (see #51). I'm leaving is issue as open for now, so no one else creates issues related to this one.
For some reason modders prefer to use isSideSolid (apart from Bibliocraft which doesn't even do anything to signify the block's sides' solidity). Perhaps an extra check? It's quite a hotspot so it would need testing.
I'm messing with the idea of adding an optional canFluidFlow bool tag to the config whitelist & blacklist args, which'll offer a workaround until the mods can fix the issues themselves.
which'll offer a workaround until the mods can fix the issues themselves.
Unfortunately, I doubt this will happen. Very few mods are still maintained for 1.12, or would even make another release even if a fix were contributed by the community.