Fluidlogged API

Fluidlogged API

305k Downloads

Incompat. with Better Builders Wands.

MagmaBro123 opened this issue ยท 11 comments

commented

Describe the bug
Better Builders Wands with this mod do not function at all.

To Reproduce
Steps to reproduce the behavior:
Install this mod with Better Builders Wands and try using its wands like usual.

Expected behavior
Better Builders Wands working like normal.

Screenshots
Normally you'd see white hitboxes showing what the wand is gonna make. Using the wand does nothing.
2022-04-14_07 00 59

Logs
No logs related to this occur.

Additional context
N/A

commented

Ah, alright. Sorry for not mentioning.

commented

what are you apologizing for? you're all good :)

commented

That's very strange, I'll see if I can fix it. Sorry for the late reply, taking a short break from this mod due to being burned out

commented

You're good. Though this and the Phosphor issues are kinda preventing me from using this.

commented

After some testing, the issue lies with Better Builder's Wands. It uses a bad targetBlock.isReplaceable check here, I'll asm patch it the meantime, since I doubt the mod will update anytime soon (no curse releases and no recent git activity)

commented

fixed in v1.8.0

commented

yes, just not released to curse yet, working on removing mixins first

commented

Been a while, has this been fixed yet?

commented

@jbredwards Apparently 1.8.0 now causes a render crash with the mod

https://pastebin.com/5bEKzX7U

commented

Thanks!

commented

welp, apparently builder's wands doesn't like ClassWriter.COMPUTE_FRAMES, fixed in v1.8.1b