Roguelike Dungeons -- Fnar's Edition

Roguelike Dungeons -- Fnar's Edition

Mods
13M Downloads

Themes without bases fail to generate dungeons

srwaggon opened this issue ยท 1 comments

commented
commented

Tested with

{
  "name": "dungeon",
  "inherit": ["builtin:base"],
  "themes": [
    {
      "primary": {
        "door": {"name": "minecraft:iron_door"},
        "floor": {"name": "minecraft:prismarine", "meta": 0},
        "walls": {"name": "minecraft:prismarine", "meta": 1},
        "pillar": {"name": "minecraft:quartz_block", "meta": 2},
        "stair": {"name": "minecraft:quartz_stairs"},
        "lightblock": {"name": "sea_lantern"},
        "liquid": {"name": "minecraft:water"}
      },
      "secondary": {
        "door": {"name": "minecraft:iron_door"},
        "floor": {"name": "minecraft:prismarine", "meta": 0},
        "walls": {"name": "minecraft:prismarine", "meta": 1},
        "pillar": {"name": "minecraft:prismarine", "meta": 2},
        "stair": {"name": "minecraft:quartz_stairs"},
        "lightblock": {"name": "sea_lantern"},
        "liquid": {"name": "minecraft:water"}
      }
    }
  ]
}

also tested with the inherited property removed.

In both cases, the dungeon spawned fine. I suspect that dungeons with all blocks defined will spawn fine.

Even tested with

{
  "name": "dungeon",
  "themes": [
  ]
}

Once again, the dungeon spawned fine (just empty since nothing else is defined). I'm considering this fixed through general code improvement.