[Bug]: Inconsistent CTM
WenXin20 opened this issue ยท 4 comments
Minecraft version
1.19
Forge version
v43.2.3
FramedBlocks version
v6.7.0
Describe the bug
Framed panels don't have connected textures on the inner half of the block, so when used for windows, one side won't have ctm.
How to reproduce the bug
- Place Framed Panels
- Use Glass Blocks
- Installed MC Connected CTM
Expected behavior
Both sides should have ctm enabled.
Additional details
Crash log
No response
6.7.0 contains a major rework of how I handle connected textures support, which includes removing support for CTM's proprietary facade system (allows them to ask my blocks what they actually look like) and replacing it with Forge's improved implementation of such a system. CTM however has yet to implement support for this new system (Chisel-Team/ConnectedTexturesMod#173 (comment)). The reason I decided to remove it immediately was the major maintenance burden it had.
TL;DR: Support for CTM is broken at the moment and fails spectacularly under certain conditions:
As for the actual question at hand and ignoring the broken CTM support: the improvements made in the aforementioned rework include preliminary support for connected textures on faces that aren't on the outer edge of the block and/or don't cover the full area of the face (the back sides of the panels in your screenshot are an example of the former and their sides and top and bottom are examples of the latter). The behaviour of that isn't perfect yet though and currently causes connections towards blocks it shouldn't connect to, which is one reason why the config for this currently defaults to only work on the faces where your screenshot shows it working. Unfortunately however, at this point in time I don't see any way of supporting CTM in this extended connected textures support because I have no way of accessing the data that identifies a unique combination of connections to neighbors, which I need in order to cache the quads you see in the end, so only the faces that already appear to be working now will also work when CTM implements support for Forge's appearance API.
I'll keep this issue open until CTM at least properly works on the parts that already appear to work. I won't hold my breath for the extended support though.
Connected textures support has been significantly improved in the 1.20.1 update which was just released. Due to the amount and type of changes, this can unfortunately not be backported to 1.19.2. Issues like the connection weirdness in my screenshot above will have to be dealt with on a case-by-case basis with the individual CT mods (CTM, Create, XyCraft, Fusion and Athena are the ones I'm aware of). As such, I'll close this issue for now and deal with the individual issues as they come up.