FramedBlocks

FramedBlocks

45M Downloads

[feature] Architectural features?

Syndaryl opened this issue · 9 comments

commented

Are items intended for detailing in scope for this project? I'd love items like

  • pillars, fluted pillars
  • fancy tops and bottoms for pillars
  • crown molding, floor molding, cornices - trims for the tops and bottoms of walls, around doors
  • Window sill, door sill
  • grate/screen (like, small-holes grate, horizontal or vertical, appropriate for drainage or containing small animals, sort of a glass or bars alternative, but orient-able)

I'm not sure if smaller details like this are part of the concept. I'd be happy to work on OBJs for the models.

commented

I have now added a Framed Pane block that works like the glass panes and a Framed Bars block that works exactly like the vanilla iron bars.
Any more detailed blocks like the grate and pillars discussed above will be added in the architecture themed addon when I get the time to start working on that.

commented

Most of these very detailed features are out of scope for FramedBlocks itself. I might make an add-on mod in the future dedicated to architectural features, though the blocks will be very blocky and not at all rounded.
I appreciate your offer with the OBJ models but unfortunately all models have to be generated fully in code (apart from most item models) due to how the mod works.

I will look into adding a grate style block similar to the iron bars including a horizontal variant.

commented

Appreciate the interest, and thank you for investigating the iron bars! If you don't mind, I'd like to look into how the models are generated in code, and see if I can script up something to translate the OBJs to your code style.

(EDIT: The nice thing for me about OBJ is that it's a dead-simple text format, so trying to transform it doesn't need much research.)

I definitely get the desire to stay away from rounded shapes! This is the sort of thing I was thinking about:
image

commented

Back left is a standard cobblestone block for comparison/size reference. Front left to right: Pillar, pillar with base, fluted pillar, fluted pillar with base, grate with no frame, then back center: large fluted pillar (can't have a base, it goes right to the block boundary) and then grate with frame.

commented

(I'm of two minds on the Grate - should it be edge-aligned, like a trap door, or center-block, like a glass pane?)

commented

Appreciate the interest, and thank you for investigating the iron bars! If you don't mind, I'd like to look into how the models are generated in code, and see if I can script up something to translate the OBJs to your code style.

The system is in theory very simple: I take the original block (cobblestone or whatever), get all quads, duplicate them and then manipulate them (cut, rotate, etc.) to create the desired shapes. If a quad fills the whole block face according to a block-specific Predicate, then it is excluded from the manipulation and gets passed through directly from the model of the "camo" block. This allows stuff like the ConnectedTexturesMod to atleast work on some of the block faces. This monstrosity contains all the manipulation helpers and this is a fairly simple example of those in action. This is one of the more "complex" models, as you can see the code gets fairly long with more faces.

I definitely get the desire to stay away from rounded shapes! This is the sort of thing I was thinking about:

This style of models would be a very good fit for an architecture themed add-on to FramedBlocks and the current systems would be able to handle that. I like it a lot.

(I'm of two minds on the Grate - should it be edge-aligned, like a trap door, or center-block, like a glass pane?)

My idea was to make the "Framed Bars" work equivalent to the Iron Bars.
The Framed Grate would be an additional block and would be placeable edge-aligned as well as centered on the block and would probably also be a prime feature for the architecure-themed add-on. In terms of model I would probably go for the grate with a frame, though I could also add both and allow the player to switch between the variants on a block-by-block basis.

commented
commented

Fixed the link. It's the "xfacthd.framedblocks.client.util.BakedQuadTransformer" class.

commented

I have finally found the time to start work in the architecture themed addon.
The blocks suggested in the screenshot above have been added.
Any further suggestions should be posted on the FramedArchitecture repository.