[Bug] Emissive textures affected by sky light
deftesthawk opened this issue · 8 comments
Version Info
- Minecraft 1.20.1
- Fusion 1.2.4 for Fabric 1.20.1 and Fusion 1.2.4 for Forge 1.20.1
Mod Loader
- Fabric and Forge
Are you using OptiFine:
- No
Description of the Bug
I noticed emissive textures using fusion seemed darker than alternative mods, like Continuity, MoreMCMeta, Connectedness etc.. After further inspection the emissive textures seem to be affected by the sky light as when the block is placed outside the top of the block is almost perfect in brightness however the side textures appear darker and the bottom texture is even darker. When placing the block in an enclosed area (without any sky light) all sides appear noticeably darker.
Steps to Reproduce
enable your example diamond emissive ore resource pack and view the block from different angles from an enclosed area and then from an area directly beneath the sky.
Screenshots
These screenshots show diamond ore blocks, the left uses fusion to make it emissive and the right uses continuity.
Here is a resource pack I created, it allows you to compare Fusion emissive texture brightness with Continuity.
Emissive Diamond Ores.zip
Info for if you want to use this resource pack to test it:
Using the Fabric mod loader, install Fusion and Continuity, place diamond ore and deepslate diamond and compare the difference.
The resource pack changes deepslate diamond ore texture to use the stone diamond ore texture.
The stone diamond ore uses Fusion to make it emissive
The deepslate diamond ore uses Continuity to make it emissive
It seems the remaining difference between Fusion and Continuity was due to ambient occlusion. This would only be apparent when other blocks are placed diagonally in front of the emissive texture.
I have now changed it so ambient occlusion will always be disabled for emissive quads which should finally properly fix the issue.
Thank you for reporting the issue and helping test and debug it!
It seems this was caused by shading still being applied to the emissive quads making them slightly darker then they should be. It should be fixed now in Fusion 1.2.5 for all versions Fusion is available for.
Thank you for reporting the issue, especially the resource pack you gave made it really easy for to compare and debug the issue! 🙂
I hate to say this, but it doesn't seem like its fixed. You definitely improved it though, which is great, so I understand if you leave it as it is 😅
Either I might just not have noticed there was still a difference or it might be a Forge specific issue as I only tested on Fabric.
What mod are you using besides Fusion to compare it to? I know of Connectedness as the Continuity port for Forge, but that is only available 1.18.2 and 1.19.2 and as far as I can tell, MoreMCMeta does not add anything for emissive textures.
I'm using continuity to test it, here's some screenshots from me testing it without any other mods installed. Only fusion installed on one test and only continuity and sinytra connecter installed on the other.
I do use a high end OLED TV, so maybe they stand out for me more.