[Bug] [Feature] Emissive non solid blocks + Items
deftesthawk opened this issue · 4 comments
Version Info
- Minecraft 1.20.1
- Fusion 1.2.4 for Fabric 1.20.1
Mod Loader
- Fabric
Are you using OptiFine:
- No
Description of the Bug
Trying to make a non solid block emissive using fusion results in it having the purple and black missing texture, I have attached my test resource pack which tries to make the Amethyst Cluster block emissive using fusion, but instead has a missing texture. I'm guessing this isn't a feature that is built into the mod, unless I'm doing it wrong?
Additionally support for emissive items would be cool too, though not necessary.
Steps to Reproduce
- Install fusion
- Download and enable the resource pack attached
- Place Amethyst Cluster down and to view the missing texture.
As far as I can tell, the issue is simply that the block/amethyst_cluster_e model uses "parent": "minecraft:block/cross", but does not specify a texture for the cross key used in that parent model. block/amethyst_cluster_e only specifies an all key which goes unused.
Changing the all key to cross seems to make the texture work and results in emissive looking amethyst clusters. So I believe it is just a simple mistake.
As for items, emissive textures should already work on item models the same they do for blocks. Indeed testing it with the resource pack you provided by changing the texture for item/amethyst_cluster from block/amethyst_cluster to block/amethyst_cluster_e, the amethyst cluster item always looks bright.
Emissive textures work the same for items and blocks.
Just create a texture with metadata for the base texture type and "emissive": true. Then use that texture in a base type model.
In the resource pack you shared, the main issue I see is that you used the format for block model modifiers for the emissive_amethyst_shard item model modifiers. Item model modifiers use a different format as their main purpose is for conditional model selection. https://github.com/SuperMartijn642/Fusion/wiki/Item-Model-Modifiers
Easiest would be to just add metadata for the regular item/amethyst_shard texture to make it emissive and make the item/amethyst_shard model into a base model. There is no need to use an item model modifier or additional models or textures that way.
Thank you, I really appreciate the help :) I didn't realize I had to use the cross key.
What about items that don't use block textures? For example the amethyst shard, here is my attempt at trying to get it working.
I removed all other files to make it easier to navigate