Fusion (Connected Textures)

Fusion (Connected Textures)

40M Downloads

[Bug] DefaultConnectionPredicates.isFaceVisible() generates "type": "fusion:is_same_block"

robert-harbison opened this issue · 1 comments

commented

Version Info

  • Minecraft, 1.21.1
  • Fusion, 1.2.7b

What mod loader are you using?: NeoForge

Are you using OptiFine: No

Description of the Bug
When generating data, DefaultConnectionPredicates.isFaceVisible() generates:

{
            "type": "fusion:is_same_block"
}

I would expect it to generate:

{
            "type": "fusion:is_face_visible"
}

This is caused by the fact that DefaultConnectionPredicates.isFaceVisible() uses IsSameBlockConnectionPredicate.INSTANCE instead of IsFaceVisibleConnectionPredicate.INSTANCE.

Steps to Reproduce
Use DefaultConnectionPredicates.isFaceVisible() to describe a connection when generating a model using ConnectingModelDataBuilder.

commented

Probably me copy-pasting the existing method for is_same_block and forgetting to change it 🙃
It should be fixed now in Fusion version 1.2.8.
Thank you for reporting the issue!