Version Info

• Minecraft, 1.21.1
• Fusion, 1.2.11a

neoforge .207

Are you using OptiFine: no lol

Description of the Bug

https://mclo.gs/0mp9DDC

Steps to Reproduce

use fusion

Screenshots

no

its giving errors about parsing on removed mods blocks, idk why

?

Can you perhaps give an example of what you mean? That log is more than 20000 lines.

from line 6886

Failed to parse block model overlay 'pfw_aesthetic_gems:emissive_smoky_diamond_deepslate_ore': Could not find a block for model overlay target 'pfw_aesthetic_gems:smoky_diamond_deepslate_ore'!

That would imply you have a resource pack adding a model modifier pfw_aesthetic_gems:emissive_smoky_diamond_deepslate_ore which targets pfw_aesthetic_gems:smoky_diamond_deepslate_ore, but there is no block with that identifier.
That would be up to that resource pack and has nothing to do with Fusion.

thing is, i dont have any resource pack that does that

Are you sure? The log shows you have all these resource packs enabled:

Excalibur_V1.21.4.zip, Excalibur Deeper and Darker Support.zip, Aether_Excalibur_Support.zip, Excalibur_Create Addon_NeoForge_v2.1.zip, Excalibur Advanced Netherite Support.zip, Excalibur End Remastered Support.zip, Excalibur Dis-Enchanting Table 1.6.zip, Excalibur Illager Invasion 1.3.zip, Excalibur Amendments 1.4.zip, Excalibur_Supplementaries_0.2_1.21.1.zip, Excalibur_Lootr.zip, Excalibur Eternal Nether 1.0.zip, Excalibur_Apotheosis Addon_v1.9.zip, Excalibur FriendsFoes 2.7.zip, ExcaliburIceFireCEfix.zip, Excalibur_It_Takes_a_Pillage_1.0.zip, Excalibur Bosses'Rise 1.2.zip, MandalasGUI Dakmode_1.21.6_v2.0.zip, Mandala Utopia.zip, MandalasGUI_AddOn DarkModded_V3.7.zip, waystones_1.21.1.zip, Fancy_Beds-v4.0.zip, Fancy Crops v1.2.zip, TNBN.zip, GEO - v1.81.0.zip, GEO - v1.81.0 - Fusion.zip, VanillaTweaks_r450139_MC1.21.x.zip, Better SB Upgrades.zip, Suren Sophisticated Storage v2.0.0 1.21-1.21.1.zip, Icons v.1.11.5 - NoLanguageMenu.zip, Icons Branding Remover 1.21.1.zip

If you disable them, do you still get the error messages?

wait, i might have an idea, it might be the Geo Fusion one, since it adds support for emissive glowing ores to all mods , which includes the one listed in the logs

Hey, yeah this is caused by my resource pack due to it adding support for a lot of mods. Is there a way to prevent these errors from appearing in the logs? As the user isn’t meant to install all the mods it adds support for.

It's not really a massive issue, as from what I gathered the issue is that the .log file becomes cluttered with these errors. I believe the standard for assets is that they aren't used unless the user has the specific mod installed that uses them, but I'm guessing fusion model_modifiers don't work like this, which is why it logs these errors when any supported mod is missing.

It is the same as referencing modded blocks from a vanilla item model definition file, for example. Vanilla will also throw an error when referencing missing registry entries.

The typical solution is to use a resource condition from the relevant mod loader to check whether a mod is present or whether a registry entry exists. However, that would require a different file per mod loader as the formats are different.

As for something in Fusion to address this, I am leaning towards adding conditions to vanilla's pack overlays. Rather than just specifying a pack format range, it would have an additional conditions field where you can check if a mod is loaded. Using the vanilla pack overlays would mean you also get its features like filtering files from lower ordered resources.
(This might still require a different solution for older Minecraft versions as the overlays were only added in 1.20.2)

For convenience, I might also ignore registry entries from namespaces where there is no mod loaded with a mod id matching that namespace. I would have to make sure there's no cases where you would not have an associated mod like things added by a datapack.