Fzzy Config

Fzzy Config

15M Downloads

Config pop up titles not translated

MincraftEinstein opened this issue ยท 7 comments

commented

The title text at the top of config pop ups inherits the config translation key, however, if the language gets changed the pop up title remains in English. Tested this with enum pop ups and list pop ups, but I assume it's the same for all config pop ups

Minecraft Version: 1.21.1
Mod Loader: Fabric and NeoForge
Mod Version: 0.6.7

commented

Are you using external @Translation annotations for those entries?

commented

not on the entries themselves, but i am on the class

commented

Hmm ok. And you said the Config name is appearing in the popups? That's not intended behavior already, as the Setting name is supposed to be the popup title for most if not all setting popups.

commented

Demonstration:
Image

Image
Probably should have done this from the start

commented

I can't replicate this in my testmod. Spanish on the below Choice option switches back and forth just fine. Switched between languages a few times and opened the popup after each switch. Tested with an enum too. This is in 1.21.3, but I don't think they've changed the behavior of translated text that much between the versions... Once I'm ready to start pulling commits to other versions I'll do some more checking

Image

Image

commented

Ok, using @Translation at the class level (and probably at the setting level) does lead to this issue, which was my suspicion. "Traditional" translation is not affected.

commented

fixed in 0.6.8