Fzzy Config

Fzzy Config

15M Downloads

Basic Validation Not Reporting Errors

fzzyhmstrs opened this issue ยท 4 comments

commented

In the deserializer, basic validation is not given a chance to report on its errors. This may have the side effect of not allowing updates to propagate correctly.

  • Line 632 in ConfigApiImpl doesn't then check "thing" for errors and report them if errored.
  • Test that removing of lines from config files themselves does still lead to self-repair of the files.
  • can tear out "newErrors" and put error reporting all back on the errorBuilder.
  • flags composition appears to also be missing from the basic validation section.
  • ValidatedAny may not be properly reporting it's actions, restart state, etc. to the deserializer. Test changing a restart-requiring prop inside an Any to see if it gets caught. Will have to determine a way to spoof that change into happening for the Any I want.
  • Deregister all but one config, and have that config have nothing but the basic validation Any. Cut down our debugging to barebones.
  • Also set up the one config to be SEPARATE, and use that for testing in the server.
  • Setup simple 1.21.5 Fabric server using the 1-config testmod
  • Configs with "spare" toml fields don't report those as errors for trimming via file re-write.
commented

Moving the restart passing to 0.7.0 or 0.6.10. Need the upgraded ValidationResult Error framework in place

commented

With one field removed from any1 in test config 3, values are not updated into the live config model. The file is being updated, however, back to default values. Somewhere in the chain errors are being raised and the default is being used.

Image

Image

Image

commented

Confirmed that making a change to a restart-causing field inside of an Any that otherwise is not restart-causing will not trigger the message; likely won't trigger the update prompt either.