Galacticraft Legacy

Galacticraft Legacy

2M Downloads

[Bug]: Translation Keys sharing the same name with other mods because they don't use the mod ID

Boiber opened this issue ยท 2 comments

commented

Forge Version

14.23.5.2859

Galacticraft Version

4.0.6

Log or Crash Report

There are some desh items that share the same translation key as some items from hbm, regardless of the seperate mod ID, with desh: (hbm:desh_sword, hbm:ingot_desh, hbm:desh_axe, and hbm:desh_hoe) and titanium: (hbm:titanium_pickaxe, hbm:titanium_axe, hbm:titanium_shovel, hbm:titanium_hoe, hbm:titanium_sword, hbm:titanium_helmet, hbm:titanium_boots, and hbm:ingot_titanium). This makes it a pain for modpack developers (such as myself) who want to have these 2 mods in the same pack, and since the translation key is the same CraftTweaker also cannot do anything about it. Making the translation keys include the mod ID would fix incompatibility with other mods, such as HBM.

Reproduction steps

Just launching the game with both the mods already messes some things up (some of the Galacticraft items, like the desh tools got renamed to 'Worker's Alloy', like the desh tools from HBM are named, which is possibly a bug from the translation keys. It gets even worse when you try to solve more incompatibility with CraftTweaker, such as trying to remove certain bugged recipies, and trying to rename items (such as 'titanium' (galacticraft) to 'dark titanium', or 'desh' (galacticraft) to 'spesh' (space desh, the names are kinda just placeholders atm, but the problem still stands), but since some of the translation keys are the exact same and don't include the mod ID, it also renames the hbm items that share the same key, which it's not supposed to do.

commented

What's "HMB"?

commented

HBM refers to a nuclear tech mod.