[Legacy] GeckoLib Fabric

[Legacy] GeckoLib Fabric

Mods
3M Downloads

[Forge 1.16.5] getRenderType and getRenderColor are redundant and useless in ItemGeoRenderer

mcpecommander opened this issue ยท 1 comments

commented

Starting from this line:

geckolib/src/main/java/software/bernie/geckolib3/renderers/geo/GeoItemRenderer.java

Line 98 in 549fbe9

protected RenderType getRenderType(T tile, MatrixStack stack, IRenderTypeBuffer bufferIn, int packedLightIn,

The two methods mentioned in the title are useless and don't get called. There are two identically named methods in IGeoRenderer that are used in the render method instead.

geckolib/src/main/java/software/bernie/geckolib3/renderers/geo/IGeoRenderer.java

Line 113 in 549fbe9

default RenderType getRenderType(T animatable, float partialTicks, MatrixStack stack,

While these two methods don't hurt or crash anything, they are quite confusing since overriding them instead of the IGeoRenderer's ones will not run the code.
If you can possibly delete these two methods, it would make it clearer which to use.

commented

closing as fix you pr'd was merged