Incompatibility between Geckolib and Discord Integration because of library com.fasterxml.jackson.core
ErdbeerbaerLP opened this issue ยท 7 comments
Geckolib and Discord Integration seem to be incompatible, because both mods use and include com.fasterxml.jackson.core
as dependency. Both mods compile with shadowJar and relocate the related package, so I assume that it should actually not cause problems like this to happen. Opening this issue as I am looking for help solving this incompatibility.
The error message is java.lang.module.ResolutionException: Modules dcintegration and geckolib3 export package com.fasterxml.jackson.core to module gamemenumodoption
Related issue:
ErdbeerbaerLP/DiscordIntegration-Forge#344
Hmm that is a weird one since yeah it shouldn't be possible. I'll peak more her later
Also not compat with fancyDiscord
https://www.curseforge.com/minecraft/mc-mods/fancydiscord?comment=1
Server log-
https://gist.github.com/ProsperCraft/92cc7fd99ba3a117a44dbded4e8c8e09
Open the jar file into any archive viewer, go to /META-INF/services/
and delete everything that starts with com.fasterxml.jackson.core
.
Those service files should not work anymore since the classes it points to has a different name now. But is still enough to trigger java module conflicts. Maybe it can be excluded in the shade task?
@juanmuscaria we do it under packageSources but I'll throw it in shadowjar as well
Alright, that fixed it perfectly! I've pushed this change to all 1.15.2, 1.16.5, 1.17.1 of Forge and 1.16.5, 1.17.2, and 1.18 snapshot versions as well!