[Bug] `model` variable in `GeoEntityRenderer` is used for animations instead of the return value of the `getGeoModel` method

Question

[Bug] `model` variable in `GeoEntityRenderer` is used for animations instead of the return value of the `getGeoModel` method

thomasglasser opened this issue 6 months ago · 5 comments

thomasglasser commented 6 months ago

The entity animations are handled by the model variable instead of the method, so overriding it doesn't change animations used.

GeoEntityRenderer lines 218 & 219:

			this.model.addAdditionalStateData(animatable, instanceId, animationState::setData);
			this.model.handleAnimations(animatable, instanceId, animationState);

Tslat · Answer 1 · 2024-05-01T22:49:20.000Z

What version of geckolib is this in?

thomasglasser · Answer 2 · 2024-05-01T22:56:26.000Z

4.4.4, mc 1.20.4

Tslat · Answer 3 · 2024-05-01T22:59:31.000Z

This was fixed in 4.5

thomasglasser · Answer 4 · 2024-05-01T23:10:23.000Z

Is 4.5 coming to 1.20.4 or do I have to just override it manually for this version

Tslat · Answer 5 · 2024-05-02T01:19:43.000Z

You should be moving on from 1.20.4 lol

Share to