[Legacy] GeckoLib Fabric

[Legacy] GeckoLib Fabric

Mods
4M Downloads

ItemStacks share the same STACK_ANIMATABLE_ID_COMPONENT after cloning in creative mode

Mishin870 opened this issue · 1 comments

commented

It's not really a library problem, but rather a minecraft problem

I have an animated item that has an inventoryTick method that has the following code in it:

var id = GeoItem.getId(stack);
var animationController = getAnimatableInstanceCache().getManagerForId(id).getAnimationControllers().get("controller");

var isSprinting = entity.isSprinting();
var isTriggeredSprinting = animationController.isPlayingTriggeredAnimation() && animationName.equals("sprinting");

var activeStack = ((PlayerEntity) entity).getMainHandStack();
var isActiveStack = activeStack == stack;
var isActiveStackAndSprinting = isSprinting && isActiveStack;

// The animation of an inactive ItemStack must be forced to idle
if (isActiveStackAndSprinting && !isTriggeredSprinting) {
    animationController.tryTriggerAnimation("sprinting");
} else if (!isActiveStackAndSprinting && isTriggeredSprinting) {
    animationController.tryTriggerAnimation("idle");
    animationController.stop();
}

And when I have two items with the same STACK_ANIMATABLE_ID_COMPONENT in my inventory, they behave as follows:

java_2025-02-19_15-18-03-932.mp4

If I try something like this:

if (isActiveStack) {
    if (isSprinting && !isTriggeredSprinting) {
        animationController.tryTriggerAnimation("sprinting");
    } else if (!isSprinting && isTriggeredSprinting) {
        animationController.tryTriggerAnimation("idle");
        animationController.stop();
    }
}

Then it works as expected, but when switching to an inactive item I'll see it suddenly go from sprinting to idle

java.2025-02-20.04-31-58-909.mp4

Because the sprinting animation wasn't turned off in it earlier
But if I try to turn it off, it will also turn off the animation of the active item, because of the same id

commented

Fixed in next release

  • ❤️1