[Legacy] GeckoLib Fabric

[Legacy] GeckoLib Fabric

Mods
4M Downloads

[1.20.1] v4.71 breaks `AbstractContainerMenu` slot listener implementation due to faulty Mixin code

Fuzss opened this issue ยท 0 comments

commented

This is causing problems like this one: Fuzss/easyanvils#96

The issue lies here:

geckolib/Forge/src/main/java/software/bernie/geckolib/mixin/common/AbstractContainerMenuMixin.java

Line 33 in be8fe53

return ItemStack.matches(stack, other) &&

This should be:

    public boolean geckolib$forceGeckolibIdSync(ItemStack stack, ItemStack other) {
        return ItemStack.matches(stack, other) &&
               (!stack.hasTag() || !stack.getTag().contains(GeoItem.ID_NBT_KEY) ||
               !other.hasTag() || !other.getTag().contains(GeoItem.ID_NBT_KEY) ||
               stack.getTag().get(GeoItem.ID_NBT_KEY).equals(other.getTag().get(GeoItem.ID_NBT_KEY)));
    }

Also goes for the other method in the class.