GeckoLib

GeckoLib

155M Downloads

Shader Armor Reflections incompatible

wisefries opened this issue ยท 13 comments

commented

When using Iris shaders supporting labPBR resource packs, armor reflections are not present.

Active mods:

  • GeckoLib 4.2.4
  • Iris
  • QFAPI
  • Sodium

To replicate, use any shader with labPBR resource pack support, e.g. Complementary Reimagined, and a resource pack with PBR formatted textures, e.g. DefaultPBR. (Modrinth links)

Intended effect, with Iris and Sodium:
Iris
When GeckoLib is present:
Gecko

commented

Using 1.20.6 (v4.5.2): No change, same issue

commented

Damn

commented

Can this be tested in 1.20.6+ pls

commented

Update the mod then?

commented

my mistake, I mistyped 4.2.4 instead of the current version, 4.4.2. It's just a minor incompatibility that I thought I should mention.

commented

I'm having the same issue with the same mods. Both POM and reflections (from resource packs using labPBR) on all movable entities (e.g. boats, minecarts, etc.) do not render.

commented

If you disable geckolib's mixins by removing the mixins from the mixins.json in the jar, does it fix it?

commented

Yes, doing that fixes it. The POM and reflections render normally.

commented

I see

commented

I also ran into this issue. I was running Patrix textures and noticed that the squids and iron golems were no longer reflective/shine. I tested all versions of Geckolib available on Modrinth (4.2.1 to 4.4.6). None fixed the issue.

Like it was suggested earlier, I opened the geckolib.mixins.json file contained in the .jar file, removed the entries in the "client" section so it is a set of empty brackets [ ].

This fixed the issue.

For those interested you can open a .jar file by changing the .jar to .zip and then open the archive. You can then open the .json file with a text editor like notepad. save the edited .json file to your desktop, and then drop and replace the old .json in the .zip file. when done, rename the .zip file back to .jar.

If there is a better way to temp patch this mod let me know. I can also test any potential fixes here as well.

MC 1.20.1
Fabric
Iris
Sodium
Lithium
Indium
Continuity
Entity Model Features
Entity Texture Features
Vanadium (colormatic replacement)

BSL shaders
Patrix texture pack

commented

Actually, and since you asked, you can only remove the "client.TextureManagerMixin" (and the comma in the line above), you don't need to remove all of them.

commented

I can't seem to replicate this on 1.21 4.5.5?

image

commented

Good news
I've figured out what's causing this and how to fix it

Bad news
Fixing it properly is quite problematic, so it'll take me some time to figure out how I want to approach it