GeckoLib

GeckoLib

Mods
146M Downloads

[Bug] `model` variable in `GeoEntityRenderer` is used for animations instead of the return value of the `getGeoModel` method

thomasglasser opened this issue ยท 5 comments

commented

The entity animations are handled by the model variable instead of the method, so overriding it doesn't change animations used.

GeoEntityRenderer lines 218 & 219:

			this.model.addAdditionalStateData(animatable, instanceId, animationState::setData);
			this.model.handleAnimations(animatable, instanceId, animationState);
commented

What version of geckolib is this in?

commented

4.4.4, mc 1.20.4

commented

This was fixed in 4.5

commented

Is 4.5 coming to 1.20.4 or do I have to just override it manually for this version

commented

You should be moving on from 1.20.4 lol