Geckolib 4.5 fails to resolve some math expressions that older Geckolib versions could resolve
NordAct opened this issue ยท 1 comments
If you try to add some "offset" for either sin or cos functions, this will result in Geckolib not resolving those functions correctly (or preventing querys from working correctly, idk what is exactly happening here). Like:
25+math.sin(query.anim_time*360/4-90)*3 - being passed as angle, this will result in bone being constantly angled at 25 degrees on axis where this expression was put and it will not change over time despite the query. Similar result also happens if you try to add value rather than substract, or use such expression for changing bone position or scaling
25+math.sin(query.anim_time*360/4)*3 - this will work and change over time just fine
Some videos with demonstration of the bug:
- MC version 1.20.6, Geckolib 4.5.1: https://youtu.be/sSW8BL7_2o4
- MC version 1.20.4, Geckolib 4.4.4: https://youtu.be/mmWuiEUmcyI
Exact same model, exact same animation files. In Blockbench animation matches the one shown in video with Geckolib 4.4.4
Link to repos of the mod with links relevant files:
-
1.20.6, Geckolib 4.5.1:
-
1.20.4, Geckolib 4.4.4:
As of logs: there's no errors or warnings regarding this.
