ItemAndBlockGeoLayer is unable to render item models that use the "neoforge:item_layers" loader
Nitespring opened this issue ยท 7 comments
https://docs.neoforged.net/docs/resources/client/models/modelloaders/
The same could be true for other custom model loaders and for their Forge counterparts
same problem for forge 1.21 for "forge:item_layers"
at TRANSFORMER/[email protected]/github.nitespring.darkestsouls.client.render.entity.mob.church.doctor.ChurchDoctorGeoRenderer.render(ChurchDoctorGeoRenderer.java:52)
GeckoLib 4 (geckolib), Version: 4.5.5
Issue tracker URL: https://github.com/bernie-g/geckolib/issues
at TRANSFORMER/[email protected]/software.bernie.geckolib.renderer.GeoRenderer.createVerticesOfQuad(GeoRenderer.java:322)
Considering that it all worked just fine in 1.20.x, I suspect it's somehow related to whatever Mojang did to rendering again in 1.21
Yeah Geckolib didn't change its internal rendering in any way in 1.21 - so it's definitely a change by mojang
What's weird is it still shouldn't affect anything, but it obviously is
I haven't had the chance to look yet, but my current assumption is that the buffer is being pushed because of a change of rendertype, which is causing it to stop building.
What's odd though is that this is not new behaviour - and that's how buffers have always worked, so I'm not sure why this is suddenly a problem now
Either way I don't think it'll be a particularly hard fix, I just want to try make sure I have it right before I do
I've got similar error with custom Animatable (i use Yarn btw).
Found temporary solution in restoring buffer if it's not building. (accessed building with access widener).
It doesn't happen if I try to apply problematic layers to entity model. As comment above says, it happens only when either BannerLayer (which is based upon BlockAndItemGeoLayer) and DragonPassengerLayer. Both work similarly and both cause stop building right after either item or entity in layer is rendered. I couldn't find the exact cause of this, but I just know that it does that.
Considering that it all worked just fine in 1.20.x, I suspect it's somehow related to whatever Mojang did to rendering again in 1.21
Crash report: https://gist.github.com/NordAct/c2ab64ef469a630b2b5adb63e6839501
I downloaded version 4.5.6 and I'm still encountering this issue:
https://pastebin.com/S9ig3A4i
