GeckoLib

GeckoLib

Mods
146M Downloads

Crashes when running in production

OroArmor opened this issue ยท 2 comments

commented

geckolib/src/main/java/software/bernie/geckolib3/util/RegistryUtils.java

Lines 92 to 101 in f8333e3

public static <T extends BlockEntity> BlockEntityType<T> registerBlockEntity(String name, Builder<T> builder)
{
if (FabricLoader.INSTANCE.isDevelopmentEnvironment())
{
BlockEntityType<T> blockEntityType = builder.build(null);
Registry.register(Registry.BLOCK_ENTITY_TYPE, new Identifier(GeckoLib.ModID, name), blockEntityType);
return blockEntityType;
}
return null;
}

I just spent around 2 hours helping someone debug why their block entity crashed in production, and it was this method. This should be changed as it is extremely misleading.

commented

This is used for geckolib example tile entities, which intentionally only work in dev. The only thing wrong here is this is in the wrong package, it should be in the example package. I will let @AzureDoom know about this.

commented

Fixed in 3.0.13.