Haema

Haema

727k Downloads

not compatible with Gunpowder-mc

Twilikid opened this issue ยท 6 comments

commented

it doesnt work with the Gunpowder MC because of /back

[09:52:12] [main/INFO]: Loading for game Minecraft 1.16.5
[09:52:12] [ForkJoinPool-1-worker-15/WARN]: The mod "autoconfig1u" contains invalid entries in its mod json:

commented

I'll have to look into that, I'm also aware FAPI implemented events we also implement, in a way that differs from ours, making large parts of our code incompatible with mods that cancel these events in their own way, so when I'm refactoring that I'll look into making an FAPI PR for this.

commented

Sorry, I completely wrote that wrong, I didn't mean to imply that I wanted you to add the events to FAPI yourself - I just meant that if somebody, whether it's one of us or not, does add them, would you be interested in using them.

Thanks :)

commented

Ah, I'll definitely look into being more compatible with FAPI with events, it's been on the TODO list for a long time :)

commented

Gunpowder Dev here. We provide a callback on this method, so you could make this mixin have a plugin that checks if we're present, and then use our provided Event in a different mixin specifically for when Gunpowder is present. These events have a cancellable pre-death and non-cancellable post-death version.

commented

Gunpowder Dev here. We provide a callback on this method, so you could make this mixin have a plugin that checks if we're present, and then use our provided Event in a different mixin specifically for when Gunpowder is present. These events have a cancellable pre-death and non-cancellable post-death version.

Thanks - I'd talked with a member of your team before, I just never got round to implementing the solution.

In the later future, would you be interested in adding pre- and post-player death events to Fabric API?

commented

Duplicate of #17, please direct further comments there