Hbm's Nuclear Tech - Extended Edition

Hbm's Nuclear Tech - Extended Edition

292k Downloads

Crash Caused By Decaying Waste Leaves

GenericBrandName opened this issue ยท 5 comments

commented

I was flying over a forest next to where a nuke went off, and it crashed. This has happened multiple times, crash report provided, something to do with the waste leaves decaying I think, but who knows.

crash-2024-02-11_16.06.01-server.txt

commented

True - vanilla minecraft leaf code is missing the null check

commented

wait a bloody second, I RECOGNIZE THIS CRASH

I HAVE BEEN WONDERING WHAT IS CAUSING IT! it happens for me when I explore the world sometimes and I thought it was a worldgen bug.

IMO im not sure if a simple empty array check (Null check) would fix this but it appears to have been an issue that was thought to be patched in the lattest release; but by the looks of the log its running the 2.0.0 version of hbm

commented

Yes it was in the most recent version, glad it's not just me

commented

the leaves are supposed to fall; but I am aware that in an older version of NTM that if it were todo this then things would break

and by the looks of the report; im curious if its the falling block portion of the code; as the blocks from a flimsty structure can collapse if in the presence of a powerful blast (whether nuclear or not is beyond me)

A second theory is that whatever was fixed may have gotten overwritten as it was done first and then the mk5 nuke generation got applyed after it and undid the purposive fix that would have occurred; hard to tell on my end and lack of knowledge of Java but is a plausable thing to happen.

(using what little I know from doing shit in zenscript)
whatever the case is; if its ment to be just leaves then whatever "Properties" its referring to lacks a nullcheck for situations where it returns an empty array based on the error specifiying that it is unable to get anything due to it being missing (a null array can be considered nothing if there are no elements in it if what I have learned from zenscript [ct stuff] translates into general code structure for java) or is using code that no longer is the case for 1.12.2 compared to stuff in 1.7.10.

commented

whatever it may be, it appears just by looking at the log that whatever is fetching the "properties" of the block is missing a nullcheck to check if what block is being ran though it even has the element or not