Hbm's Nuclear Tech - Extended Edition

Hbm's Nuclear Tech - Extended Edition

292k Downloads

Structure Missing?

MixasFox opened this issue ยท 1 comments

commented

I have noticed that radiostation is not spawning, can it be enabled in config somewhere? Same about most of the structures that have been spawning in 1.7.10 but theyre not in the mod.

commented

As i remember it's maybe a 'bug'
Because this is an 'impossible' (or almost impossible) condition in code:

if (biome.getDefaultTemperature() >= 1F && biome.getRainfall() > 1F) {
          generateAStructure(world, rand, i, j, new Radio01(), parseInt(CompatibilityConfig.radioStructure.get(dimID)));

1 ) First condition: biome temperature need to be greater than or equal to 1.
In minecraft only this biomes have >=1 temperature:
mountains (1.0)
desert (2.0)
savanna (1.0-1.2)
badlands (2.0)

2 ) Second condition: getRainfall >1
I think this is a check for possibility of rain in biome (im not that good in minecraft code-things so im not sure) - in this situation mountains could be suitable for the conditions, but i never seen Radio structure in mountains.

So I think this part of the code is either not working as intended, or it's just a simple mistake and we need to put biome.getRainfall() < 1F instead of biome.getRainfall() > 1F to allow spawn Radio in desert\savanna\badlands (biomes with high temperature and without rain).

Or if getRainfall check for humidity - there's no biomes in minecraft with humidity more than 1 (Mushroom Fields has highest humidity - only 1.0) and we need the same solution.