ICBM - Interconnected Block Missiles

ICBM - Interconnected Block Missiles

10M Downloads

Unbreakable block structures not protecting insides against explosives

keyboardcat1 opened this issue · 15 comments

commented

Unbreakable blocks such as bedrock, barriers and other unbreakable blocks from external mods don’t protect against the thermobaric and nuclear explosives. Although the block structures themselves do survive, anything contained within them gets destroyed, as opposed to reinforced concrete structures.

commented

@DarkGuardsman can I compile a version myself while I wait for the next release?

commented

Sure, but you can't host it anywhere due to copyright policy on the assets. If you set the version the same you can add it to a server.

commented

Thanks a lot! Yeah I'll just keep it to myself and my friends.

commented

Can you supply the version of minecraft, version of the mod, and picture of the setup.

commented

Minecraft version: 1.12.2, mod version: 4.0.1
Here are pictures of the setup (both structures contained crafting tables before the explosion):
2022-04-18_19 49 09
2022-04-18_19 49 16
2022-04-18_19 49 41
2022-04-18_19 49 54

commented

Bedrock should work. I'll confirm later this week. As for external mods I can't say for sure. Since I know a few do some tricks to make things unbreakable without setting the unbreakable attribute on the block. Such as a few magic mods that respawn blocks when broken. MFFS also has this issue in newer versions.

commented

Thanks! My main concern is SecurityCraft's unbreakable blocks (yes they have the unbreakable attribute), since that's our main defense mod on my server. Meanwhile we'll just have fun with the flaw :)

commented

I already did test it and SecurityCraft's reinforced blocks have the same behavior as bedrock in this case. There must be a special case for reinforced concrete in the blast code, since bedrock and SC's reinforced blocks have the same explosion resistance, while reinforced concrete is merely a little higher than obsidian's.

commented

We have no special logic as that would be annoying to maintain. The nuke works off energy vs blast resistance. Each block it breaks cost energy and will eventually cause the nuke to stop on the ray trace.

commented

At a quick glance, this is likely the culprit. The hardness of bedrock and SC's reinforced blocks is -1, while reinforced concrete's is 10. Blocks that have a negative hardness do not count towards the power calculation, resulting in the observed behavior.

if (!block.isAir(state, world, blockPos) && state.getBlockHardness(world, blockPos) >= 0)
{
//Consume power based on block
power -= getResistance(blockPos, state);

commented

Oh neat, luckily the author of security craft is part of our team.

@bl4ckscor3 any chance you can test your mod with ICBM.

commented

When will the polish be released?

commented

Is BlastNuclear.java also responsible for thermobaric explosions, since those also have the same issue?

commented

When will the polish be released?

The "1.12 Polish" project does not constitute a single version release, but merely a way to keep track of things that need to be done to polish the mod.

Is BlastNuclear.java also responsible for thermobaric explosions, since those also have the same issue?

Yes, the thermobaric explosive is a less powerful and non-nuclear version of the nuclear explosive :)

commented

Ya 1.12 polish is an on-going goal with no ETA. We will make releases as we go.

@bl4ckscor3 if you want to release an update or work with @GHXX to do so feel free. I'm in meetings til 6pm today and likely will be too burnout to do mucn.