Immersive Portals

Immersive Portals

5M Downloads

Alternate 3/4 can generate random game block sections so big they crash the server

HyperSoop opened this issue ยท 15 comments

commented

According to your testing, does the issue occur with ONLY Immersive Portals mod and Farbic API?

Yes

Describe the issue

In cursed alternate worlds there is that "biome" with all blocks in the game, and if this one generates too big, an issue arises - when having this structure loaded, the server lags to death. This may be due to water streams flowing onto it and making a lot of dropped items, but as a person more knowlegable than me said,

having all kinds of random blocks like that seems to really fuck with the chunk decoder

Whatever the laggy part of this is, I ask you to decrease the max size this structire may generate. i'm going to run a server on alternate 3/4, after all.
javaw 2022-07-31 20-11-34
(they should not be able to generate that big)

Post the log here

No response

commented

javaw 2022-08-04 09-21-12
javaw 2022-08-04 09-38-15
javaw 2022-08-04 09-28-50,
javaw 2022-08-04 09-29-40
javaw 2022-08-04 09-30-02
Just as i told that to you, i found 5 of those, none being too extreme.

commented

oh and there is a spark report taken right before the server almost crashes ๐Ÿ’€ https://spark.lucko.me/omEv1a4bbR

commented

i should really never have thought using these worlds as the main world on a production server was a good idea, not backing out now

commented

If it lags like that I will remove this kind of random block generation.

commented

If it lags like that I will remove this kind of random block generation.

Please don't remove it, just make it generate smaller. There were 2 smaller structures of this kind on the server and it was all fine.
image
In this size they still look cool and don't cause any lag.

commented

@qouteall any news on this? i'd like this fix sooner than later

commented

I made it only generate between y=0 and y=32 and built a quick release (not yet tested, it may crash)

immersive-portals-2.1.2-mc1.19.1-fabric.jar.zip

commented

I booted up the server with the new build, went to the place the big structure would have generated, and there is totally no structure of this kind there, at all. Guess the generation is very different in this version. Gotta find another one.

commented

I made it only generate between y=0 and y=32 and built a quick release (not yet tested, it may crash)

immersive-portals-2.1.2-mc1.19.1-fabric.jar.zip

Is it tied to world height or do you mean the height of the structure? Anyway, thanks a lot for the build.

commented

I think you straight up removed those/i'm unlucky, i have went like 2k blocks in a straight line and found none of those XD

commented

I didn't remove that. It's just rare.

then i'll just have to keep grinding, but i think the way you capped their height made them 5 times rarer.

commented

I didn't remove that. It's just rare.

commented

@qouteall is the change live in the latest 1.19.2 release?

commented
commented

So this is considered fixed right? Closing.