Immersive Portals

Immersive Portals

5M Downloads

Incompatibility with Astromine / Cardinal Components

copygirl opened this issue · 1 comments

commented

Minecraft: 1.16.2
Fabric API: 0.19.0+build.398-1.16
Astromine: 1.8.5+fabric-1.16.2
Cardinal Components: 2.5.2 (included in Astromine)
Immersive Portals: 0.29
(No other mods loaded.)

When attempting to create and load into a new world, the game crashes with the following exception:

[14:49:17] [Server thread/FATAL]: Mixin apply failed mixins.cardinal_components_block.json:common.MixinThreadedAnvilChunkStorage -> net.minecraft.class_3898: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException InjectionPoint(Shift)[@At("INVOKE")] on net/minecraft/class_3898::sendChunkDataPackets with priority 1000 cannot inject into net/minecraft/class_3898::method_18715(Lnet/minecraft/class_3222;[Lnet/minecraft/class_2596;Lnet/minecraft/class_2818;)V merged by com.qouteall.immersive_portals.mixin.chunk_sync.MixinThreadedAnvilChunkStorage_C with priority 1000 [PREINJECT Applicator Phase -> mixins.cardinal_components_block.json:common.MixinThreadedAnvilChunkStorage -> Prepare Injections ->  -> handler$zca000$sendChunkDataPackets(Lnet/minecraft/class_3222;[Lnet/minecraft/class_2596;Lnet/minecraft/class_2818;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Prepare]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: InjectionPoint(Shift)[@At("INVOKE")] on net/minecraft/class_3898::sendChunkDataPackets with priority 1000 cannot inject into net/minecraft/class_3898::method_18715(Lnet/minecraft/class_3222;[Lnet/minecraft/class_2596;Lnet/minecraft/class_2818;)V merged by com.qouteall.immersive_portals.mixin.chunk_sync.MixinThreadedAnvilChunkStorage_C with priority 1000 [PREINJECT Applicator Phase -> mixins.cardinal_components_block.json:common.MixinThreadedAnvilChunkStorage -> Prepare Injections ->  -> handler$zca000$sendChunkDataPackets(Lnet/minecraft/class_3222;[Lnet/minecraft/class_2596;Lnet/minecraft/class_2818;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Prepare]

I assume this has to do with your overriding of sendChunkDataPackets where Cardinal Components tries to inject into it to fire its ChunkSyncCallback event. Similar to #388.

Astromine is one of Fabric's upcoming larger content mods so it would be nice if compatibility could be achieved.
(Additionally, Immersive Portals simply feels like a must-have.)