In Control!

In Control!

72M Downloads

In Control not recognizing thousands of valid items

JonJonsonsSon opened this issue ยท 9 comments

commented

/fctrldumpitem confirms that an item is called tfc:metal/ingot/nickel , among dozens of other ingots and thousands of other items from this mod that use a similar naming scheme.
However the mod is unable to recognize any of them when attempting to use them in loot.json and other config files, possibly because of the slashes in their name. I hope this'll be fixed, as it makes some mods completely incompatible with IC all because of this one, solitary bug.

The error message for each ingot & other items: [Client thread/ERROR] [incontrol]: Unknown item 'tfc:metal/ingot/nickel'!

commented

Can you show me your loot.json file? Also version please

commented

I've since changed it a bit, but I re-added one of the ingot instances at the very bottom: https://pastebin.com/NjESsFNe
fxcontrol-1.12-0.1.6

commented

Is there something in the log? The only explanation I can have on this is that TFC does something weird with item registering so that it registers too late (after In Control has parsed its rules)

commented
commented

I suspect TFC is handling its registration of items in a special way. If that's the case there is not much I can do about it. I know In Control works fine with other modded items

commented

Huh. If it helps you narrow down the cause at all, I'm using a mod called Mob Drops Your Way that allows mobs to drop TFC items. Here's a link to it: https://minecraft.curseforge.com/projects/mob-drops

commented

If its adding stuff to LivingDrops event its likely InControl might be missing it, which should be fixable by 1. Adding Event Priority Lowest to InControls event handler and 2 (If it still acts up) making sure InControl loads after certain mods using dependencies variable in @mod

It does not help with "Mob Drops Your Way" being closed source, I will decompile to inspect what its doing to see if I can help.

commented

@SM91337 that would be helpful

commented

The reason InControl is not picking up the drops is because the mod does not add them using the proper .add method its currently using .entityDropItem

This is something GenDeathRow (If he has the source code) will need to fix as Kashdeya unfortunately passed away.