
Mob Slaughter not generating drops for Blaze
DMCK96 opened this issue ยท 5 comments
Fabric Version: 0.14.25
Tech Reborn Version: 5.8.7
Industrial Reborn Version: 1.16.5-BETA
Minecraft Version: 1.20.1
I have it killing blaze's with the 'Mob Slaughter' and they are generating liquid exp but they are not generating any drops.
Tested with skeletons and it was generating drops no problem.
Update: Could this be due to it requiring to be killed by a player to drop a blaze rod? Can we simulate a player kill or maybe a module to simulate a player kill to get around this issue?
I can see that you are using MOB_SLAUGHTER_INSTANT_KILL_BLACKLIST which switches to use player damage rather than setting their health to 0.
You already have the functionality there to enable player-kill loot.
I've tested it locally and my changes are working as intended. I've submitted a pull request and explained my changes here:
Thank you for reporting the issue! You are indeed right. Blade rods are only dropped when killed by a player. Loot table generation will need to be fixed
I've downloaded the backport branch and currently testing a version locally that only uses the player-damage mode of killing rather than the InstantKill method.
It does work however rather than generating the loot and placing it into the connected chest, it's just dropping the loot on the floor. Will tweak it further today and update you on progress.
Bit rusty with Java, been primarily writing C# for the last few years ๐
Update:
Ah okay I see you've got the adding loot to inventory as part of your instant kill method (I'd advise you keep these thing separate, you should follow the least responsibility principle when it comes to creating methods). Makes it easier to maintain and extend.
I may make some more tweaks and do a pull request to the backport branch.