Iron's Rpg Tweaks

Iron's Rpg Tweaks

468k Downloads

Enchantment Description still showing.

Drebledore opened this issue ยท 8 comments

commented

Hello! In the enchantment module, when you have enchantment description it would still show the description making identifying them null. If I may suggest, make it so it hides the entire tooltip of the item itself. This also makes it more mysterious especially if you are playing with apotheosis which adds prefixes/ random attributes to items.

commented

After some testing, I found out it was CoFH Core. I tested the loot on dungeons and it seems to be random. Some give out descriptions but mostly it works as intended.

The mods on the screenshot are RPG tweaks, CoFH core, and when dungeons arise.
enchant-desc

commented

For some reason, CoFH core places descriptions on enchanted books if they only have 1 enchantment.
It also looks like they have a client config to turn it off

commented

I have both mods installed and everything is working on my end. Can you attach a screenshot of the issue as well as all other mods you're using?

commented

2023-08-02_13 23 56
2023-08-02_13 23 54
Seems to be happening in 1.20.1, but no COFH. Just with enchantment descriptions and https://www.curseforge.com/minecraft/mc-mods/held-item-tooltips

commented

Confirmed happening in 1.20.1 with no COFH.
image

commented

Currently, it works on 1.19.2 with Enchantment Descriptions 13.0.14. Their code is identical on 1.19.2 and 1.20.1, so I would have to look into this deeper as to why it wouldn't be working
image
image
Their code on 1.19.2:
https://github.com/Darkhax-Minecraft/Enchantment-Descriptions/blob/1.19.2/Common/src/main/java/net/darkhax/enchdesc/DescriptionManager.java
Their code on 1.20.1:
https://github.com/Darkhax-Minecraft/Enchantment-Descriptions/blob/1.20.1/common/src/main/java/net/darkhax/enchdesc/DescriptionManager.java

commented

I put in a compat request with Enchantment Descriptions who pointed out that the description visibility is resulting from a bug. They pointed out in the code where they think the bug is derived.

Darkhax-Minecraft/Enchantment-Descriptions#216

//this is something dependent on the enchantment, such as a description. remove it.

commented

Correction; it does work on 1.20.1. Perceived issues may be related to mod loading order. I'll release a patch that should make sure our code gets executed last, but otherwise, this issue is resolved.
image
image